[PATCH] net/9p: trans_xen: add missing MODULE_AUTHOR/DESCRIPTION/LICENSE

From: Jesse Chan <redacted>

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in net/9p/9pnet_xen.o
see include/linux/module.h for more information

This adds the license as "Dual MIT/GPL", which matches the header of the file.

MODULE_DESCRIPTION and MODULE_AUTHOR are also added.

Signed-off-by: Jesse Chan <redacted>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 net/9p/trans_xen.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c
index 325c56043007..336576f7e9f1 100644
--- a/net/9p/trans_xen.c
+++ b/net/9p/trans_xen.c

@@ -543,3 +543,7 @@ static void p9_trans_xen_exit(void)
 	return xenbus_unregister_driver(&xen_9pfs_front_driver);
 }
 module_exit(p9_trans_xen_exit);
+
+MODULE_AUTHOR("Stefano Stabellini <stefano@aporeto.com>");
+MODULE_DESCRIPTION("Xen Transport for 9P");
+MODULE_LICENSE("Dual MIT/GPL");

-- 
2.9.0

On Wed, 10 Jan 2018, Arnd Bergmann wrote:

From: Jesse Chan <redacted>

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in net/9p/9pnet_xen.o
see include/linux/module.h for more information

This adds the license as "Dual MIT/GPL", which matches the header of the file.

MODULE_DESCRIPTION and MODULE_AUTHOR are also added.

Signed-off-by: Jesse Chan <redacted>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>

On Wed, 10 Jan 2018 17:37:47 +0100, Arnd Bergmann wrote:

Could you consider adding the credit to the people who are in this patch that addresses the same issue?

https://patchwork.ozlabs.org/patch/856908/

Thank you.

On Wed, Jan 10, 2018 at 6:27 PM, Akemi Yagi [off-list ref] wrote:

On Wed, 10 Jan 2018 17:37:47 +0100, Arnd Bergmann wrote:

quoted

MODULE_DESCRIPTION and MODULE_AUTHOR are also added.

Signed-off-by: Jesse Chan <redacted>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 net/9p/trans_xen.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c
index 325c56043007..336576f7e9f1 100644
--- a/net/9p/trans_xen.c
+++ b/net/9p/trans_xen.c

@@ -543,3 +543,7 @@ static void p9_trans_xen_exit(void)
      return xenbus_unregister_driver(&xen_9pfs_front_driver);
 }
 module_exit(p9_trans_xen_exit);
+
+MODULE_AUTHOR("Stefano Stabellini <stefano@aporeto.com>");
+MODULE_DESCRIPTION("Xen Transport for 9P");
+MODULE_LICENSE("Dual MIT/GPL");

Could you consider adding the credit to the people who are in this patch that addresses the same issue?

https://patchwork.ozlabs.org/patch/856908/

Any version is fine with me, as long as the patch makes it in. I picked
up Jesse's patch and forwarded that one, as he seems to have been
the first person to send a patch back in November.

Comparing the two versions, I think that one is also better since it correctly
identifies the license as "Dual MIT/GPL", matching the comment.

        Arnd

On Wed, 10 Jan 2018 17:37:47 +0100
Arnd Bergmann [off-list ref] wrote:

I already submitted:
  https://patchwork.ozlabs.org/patch/856908/