[PATCH] net: plip: Delete an error message for a failed memory allocation in plip_receive_packet()
From: SF Markus Elfring <hidden>
Date: 2018-01-03 15:09:24
Also in:
kernel-janitors, lkml
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
From: Markus Elfring <redacted> Date: Wed, 3 Jan 2018 16:00:23 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <redacted> --- drivers/net/plip/plip.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c
index feb92ecd1880..22f10d395d9c 100644
--- a/drivers/net/plip/plip.c
+++ b/drivers/net/plip/plip.c@@ -632,10 +632,9 @@ plip_receive_packet(struct net_device *dev, struct net_local *nl, } /* Malloc up new buffer. */ rcv->skb = dev_alloc_skb(rcv->length.h + 2); - if (rcv->skb == NULL) { - printk(KERN_ERR "%s: Memory squeeze.\n", dev->name); + if (!rcv->skb) return ERROR; - } + skb_reserve(rcv->skb, 2); /* Align IP on 16 byte boundaries */ skb_put(rcv->skb,rcv->length.h); rcv->skb->dev = dev;
--
2.15.1