DORMANTno replies

[patch net-next] net: sched: silence uninitialized parent variable warning in tc_dump_tfilter

From: Jiri Pirko <jiri@resnulli.us>
Date: 2018-01-18 08:05:57
Subsystem: networking [general], tc subsystem, the rest · Maintainers: "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jamal Hadi Salim, Jiri Pirko, Linus Torvalds

From: Jiri Pirko <redacted>

When tcm->tcm_ifindex == TCM_IFINDEX_MAGIC_BLOCK, parent is still passed
down but the value is never used. Compiler does not recognize it and
issues a warning. Silence it down initializing parent to 0.

Reported-by: David Miller <davem@davemloft.net>
Reported-by: Stephen Rothwell <redacted>
Signed-off-by: Jiri Pirko <redacted>
---
 net/sched/cls_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index e500d11da9cd..9683f8550f6f 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -1303,7 +1303,7 @@ static int tc_dump_tfilter(struct sk_buff *skb, struct netlink_callback *cb)
 	struct tcmsg *tcm = nlmsg_data(cb->nlh);
 	long index_start;
 	long index;
-	u32 parent;
+	u32 parent = 0;
 	int err;
 
 	if (nlmsg_len(cb->nlh) < sizeof(*tcm))
-- 
2.14.3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help