[PATCH net 0/2] cxgb4: fix issues in rule processing for tc-flower offload

STALE3143d

4 messages, 2 authors, 2018-01-22 · open the first message on its own page

[PATCH net 0/2] cxgb4: fix issues in rule processing for tc-flower offload

From: Rahul Lakkireddy <hidden>
Date: 2018-01-17 06:44:29

Patch 1 sets filter type to indicate IPv6 when processing flow match
parameters.

Patch 2 fixes endianness issue when processing vlan flow match parameters.

Kumar Sanghvi (2):
  cxgb4: set filter type to 1 for ETH_P_IPV6
  cxgb4: fix endianness for vlan value in cxgb4_tc_flower

 drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

-- 
2.14.1

[PATCH net 1/2] cxgb4: set filter type to 1 for ETH_P_IPV6

From: Rahul Lakkireddy <hidden>
Date: 2018-01-17 06:44:32

From: Kumar Sanghvi <redacted>

For ethtype_key = ETH_P_IPV6, set filter type as 1 in cxgb4_tc_flower
code when processing flow match parameters.

Signed-off-by: Kumar Sanghvi <redacted>
Signed-off-by: Rahul Lakkireddy <redacted>
Signed-off-by: Ganesh Goudar <redacted>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c
index d4a548a6a55c..276edcbb3259 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c
@@ -111,6 +111,9 @@ static void cxgb4_process_flow_match(struct net_device *dev,
 			ethtype_mask = 0;
 		}
 
+		if (ethtype_key == ETH_P_IPV6)
+			fs->type = 1;
+
 		fs->val.ethtype = ethtype_key;
 		fs->mask.ethtype = ethtype_mask;
 		fs->val.proto = key->ip_proto;
-- 
2.14.1

[PATCH net 2/2] cxgb4: fix endianness for vlan value in cxgb4_tc_flower

From: Rahul Lakkireddy <hidden>
Date: 2018-01-17 06:44:37

From: Kumar Sanghvi <redacted>

Don't change endianness when assigning vlan value in cxgb4_tc_flower
code when processing flow match parameters. The value gets converted
to network order as part of filtering code in set_filter_wr.

Signed-off-by: Kumar Sanghvi <redacted>
Signed-off-by: Rahul Lakkireddy <redacted>
Signed-off-by: Ganesh Goudar <redacted>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c
index 276edcbb3259..a452d5a1b0f3 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c
@@ -208,8 +208,8 @@ static void cxgb4_process_flow_match(struct net_device *dev,
 					   VLAN_PRIO_SHIFT);
 		vlan_tci_mask = mask->vlan_id | (mask->vlan_priority <<
 						 VLAN_PRIO_SHIFT);
-		fs->val.ivlan = cpu_to_be16(vlan_tci);
-		fs->mask.ivlan = cpu_to_be16(vlan_tci_mask);
+		fs->val.ivlan = vlan_tci;
+		fs->mask.ivlan = vlan_tci_mask;
 
 		/* Chelsio adapters use ivlan_vld bit to match vlan packets
 		 * as 802.1Q. Also, when vlan tag is present in packets,
-- 
2.14.1

Re: [PATCH net 0/2] cxgb4: fix issues in rule processing for tc-flower offload

From: David Miller <davem@davemloft.net>
Date: 2018-01-22 20:27:31

From: Rahul Lakkireddy <redacted>
Date: Wed, 17 Jan 2018 12:13:32 +0530
Patch 1 sets filter type to indicate IPv6 when processing flow match
parameters.

Patch 2 fixes endianness issue when processing vlan flow match parameters.
Series applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help