[iproute2 1/1] tc: Fix filter protocol output

Subsystems: the rest

3 messages, 3 authors, 2018-01-09 · open the first message on its own page

[iproute2 1/1] tc: Fix filter protocol output

From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: 2018-01-07 14:43:39

From: Jamal Hadi Salim <jhs@mojatatu.com>

Fixes: 249284ff5a44 ("tc: jsonify filter core")
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
 tc/tc_filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/tc_filter.c b/tc/tc_filter.c
index 545cc3a..546311a 100644
--- a/tc/tc_filter.c
+++ b/tc/tc_filter.c
@@ -276,7 +276,7 @@ int print_filter(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
 		if (!filter_protocol || filter_protocol != f_proto) {
 			if (f_proto) {
 				SPRINT_BUF(b1);
-				print_string(PRINT_JSON, "protocol",
+				print_string(PRINT_ANY, "protocol",
 					     "protocol %s ",
 					     ll_proto_n2a(f_proto, b1, sizeof(b1)));
 			}
-- 
1.9.1

Re: [iproute2 1/1] tc: Fix filter protocol output

From: Jiri Pirko <jiri@resnulli.us>
Date: 2018-01-07 18:35:32

Sun, Jan 07, 2018 at 03:43:28PM CET, jhs@mojatatu.com wrote:
quoted hunk
From: Jamal Hadi Salim <jhs@mojatatu.com>

Fixes: 249284ff5a44 ("tc: jsonify filter core")
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
tc/tc_filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/tc_filter.c b/tc/tc_filter.c
index 545cc3a..546311a 100644
--- a/tc/tc_filter.c
+++ b/tc/tc_filter.c
@@ -276,7 +276,7 @@ int print_filter(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
		if (!filter_protocol || filter_protocol != f_proto) {
			if (f_proto) {
				SPRINT_BUF(b1);
-				print_string(PRINT_JSON, "protocol",
+				print_string(PRINT_ANY, "protocol",
ha! Thanks!

Acked-by: Jiri Pirko <redacted>

Re: [iproute2 1/1] tc: Fix filter protocol output

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2018-01-09 16:09:48

On Sun,  7 Jan 2018 09:43:28 -0500
Jamal Hadi Salim [off-list ref] wrote:
From: Jamal Hadi Salim <jhs@mojatatu.com>

Fixes: 249284ff5a44 ("tc: jsonify filter core")
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help