[PATCH] tcp: make function tcp_recv_timestamp static

Subsystems: networking [general], networking [tcp], the rest

STALE3216d

2 messages, 2 authors, 2017-12-26 · open the first message on its own page

[PATCH] tcp: make function tcp_recv_timestamp static

From: Colin King <hidden>
Date: 2017-12-22 01:01:46

From: Colin Ian King <redacted>

The function tcp_recv_timestamp is local to the source and does not
need to be in global scope, so make it static.

Cleans up sparse warning:
symbol 'tcp_recv_timestamp' was not declared. Should it be static?

Signed-off-by: Colin Ian King <redacted>
---
 net/ipv4/tcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index ca042cdf8496..3d93ae649bbd 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -1729,7 +1729,7 @@ static void tcp_update_recv_tstamps(struct sk_buff *skb,
 }
 
 /* Similar to __sock_recv_timestamp, but does not require an skb */
-void tcp_recv_timestamp(struct msghdr *msg, const struct sock *sk,
+static void tcp_recv_timestamp(struct msghdr *msg, const struct sock *sk,
 			       struct scm_timestamping *tss)
 {
 	struct timeval tv;
-- 
2.14.1

Re: [PATCH] tcp: make function tcp_recv_timestamp static

From: David Miller <davem@davemloft.net>
Date: 2017-12-26 22:42:34

From: Colin King <redacted>
Date: Fri, 22 Dec 2017 01:01:35 +0000
From: Colin Ian King <redacted>

The function tcp_recv_timestamp is local to the source and does not
need to be in global scope, so make it static.

Cleans up sparse warning:
symbol 'tcp_recv_timestamp' was not declared. Should it be static?

Signed-off-by: Colin Ian King <redacted>
This doesn't apply cleanly to any of my trees, please be explicit about
which tree you are targetting once you fix this up, also:
quoted hunk
@@ -1729,7 +1729,7 @@ static void tcp_update_recv_tstamps(struct sk_buff *skb,
 }
 
 /* Similar to __sock_recv_timestamp, but does not require an skb */
-void tcp_recv_timestamp(struct msghdr *msg, const struct sock *sk,
+static void tcp_recv_timestamp(struct msghdr *msg, const struct sock *sk,
 			       struct scm_timestamping *tss)
If you change where the openning parenthesis of a function definition
occurs, you have to adjust the indentation of the second line of
arguments so that it starts precisely at the first column after the
openning parenthesis.

Thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help