# Re: \[PATCH v10 3/5\] bpf: add a bpf\_override\_function helper

- From: Alexei Starovoitov \<hidden\>
- Date: 2017-12-15 20:34:51 
- List: netdev
- Page: https://ratatoskr.run/netdev/2017/12/5159847
- Thread: https://ratatoskr.run/netdev/2017/12/5159795/t.md

```text
On 12/15/17 11:12 AM, Josef Bacik wrote:
> +#ifdef CONFIG_BPF_KPROBE_OVERRIDE
> +BPF_CALL_2(bpf_override_return, struct pt_regs *, regs, unsigned long, rc)
> +{
> +	__this_cpu_write(bpf_kprobe_override, 1);
> +	regs_set_return_value(regs, rc);
> +	arch_ftrace_kprobe_override_function(regs);
> +	return 0;
> +}

since you're doing a respin can you adopt the change I did to make
this helper fail at load time if that #config is not set
instead of runtime?

Also how big is the v9-v10 change ?
May be do it as separate patch, since previous set already sitting
in bpf-next and there are patches on top?

```
