From: Pavel Machek <hidden> Date: 2017-12-15 09:29:28
Hi!
quoted
In v4.15-rc2+, network manager can not see my ethernet card, and
manual attempts to ifconfig it up did not really help, either.
Card is:
02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet
Controller
From: David Miller <davem@davemloft.net> Date: 2017-12-15 15:52:18
From: Pavel Machek <redacted>
Date: Fri, 15 Dec 2017 10:28:49 +0100
Hi!
quoted
quoted
In v4.15-rc2+, network manager can not see my ethernet card, and
manual attempts to ifconfig it up did not really help, either.
Card is:
02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet
Controller
I don't see the patch in latest mainline. Not having ethernet
is... somehow annoying. What is going on there?
Generally speaking, e1000 maintainence has been handled very poorly over
the past few years, I have to say.
Fixes take forever to propagate even when someone other than the
maintainer provides a working and tested fix, just like this case.
Jeff, please take e1000 maintainence seriously and get these critical
bug fixes propagated.
Thank you.
From: "Keller, Jacob E" <jacob.e.keller@intel.com> Date: 2017-12-15 17:29:12
-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
On Behalf Of Gabriel C
Sent: Sunday, December 10, 2017 4:44 AM
To: Pavel Machek <redacted>; kernel list <redacted>
Cc: Kirsher, Jeffrey T <redacted>; intel-wired-
lan@lists.osuosl.org; netdev@vger.kernel.org
Subject: Re: v4.15-rc2 on thinkpad x60: ethernet stopped working
On 10.12.2017 09:39, Pavel Machek wrote:
quoted
Hi!
Hi,
quoted
In v4.15-rc2+, network manager can not see my ethernet card, and
manual attempts to ifconfig it up did not really help, either.
Card is:
02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet
Controller
Dmesg says:
dmesg | grep eth
[ 0.648931] e1000e 0000:02:00.0 eth0: (PCI Express:2.5GT/s:Width
x1) 00:16:d3:25:19:04
[ 0.648934] e1000e 0000:02:00.0 eth0: Intel(R) PRO/1000 Network
Connection
[ 0.649012] e1000e 0000:02:00.0 eth0: MAC: 2, PHY: 2, PBA No:
005302-003
[ 0.706510] usbcore: registered new interface driver cdc_ether
[ 6.557022] e1000e 0000:02:00.0 eth1: renamed from eth0
[ 6.577554] systemd-udevd[2363]: renamed network interface eth0 to
eth1
Any ideas ?
Hi,
Digging into this, the problem is complicated. The original bug assumed behavior of the .check_for_link call, which is universally not implemented.
I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate signaling for link check/link up", 2017-10-10) and find a more proper solution.
I don't think any other code which uses check_for_link expects the interface to return in the way this patch attempted.
Thanks,
Jake
From: "Keller, Jacob E" <jacob.e.keller@intel.com> Date: 2017-12-15 17:30:42
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf Of
Keller, Jacob E
Sent: Friday, December 15, 2017 9:29 AM
To: Gabriel C <redacted>; Pavel Machek <redacted>; kernel list
[off-list ref]
Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped
working
On Behalf Of Gabriel C
Sent: Sunday, December 10, 2017 4:44 AM
To: Pavel Machek <redacted>; kernel list <redacted>
Cc: Kirsher, Jeffrey T <redacted>; intel-wired-
lan@lists.osuosl.org; netdev@vger.kernel.org
Subject: Re: v4.15-rc2 on thinkpad x60: ethernet stopped working
On 10.12.2017 09:39, Pavel Machek wrote:
quoted
Hi!
Hi,
quoted
In v4.15-rc2+, network manager can not see my ethernet card, and
manual attempts to ifconfig it up did not really help, either.
Card is:
02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet
Controller
Dmesg says:
dmesg | grep eth
[ 0.648931] e1000e 0000:02:00.0 eth0: (PCI Express:2.5GT/s:Width
x1) 00:16:d3:25:19:04
[ 0.648934] e1000e 0000:02:00.0 eth0: Intel(R) PRO/1000 Network
Connection
[ 0.649012] e1000e 0000:02:00.0 eth0: MAC: 2, PHY: 2, PBA No:
005302-003
[ 0.706510] usbcore: registered new interface driver cdc_ether
[ 6.557022] e1000e 0000:02:00.0 eth1: renamed from eth0
[ 6.577554] systemd-udevd[2363]: renamed network interface eth0 to
eth1
Any ideas ?
Hi,
Digging into this, the problem is complicated. The original bug assumed behavior
of the .check_for_link call, which is universally not implemented.
I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate signaling for
link check/link up", 2017-10-10) and find a more proper solution.
I don't think any other code which uses check_for_link expects the interface to
return in the way this patch attempted.
Thanks,
Jake
Alternatively, we can go a step farther and make sure every implementation of .check_for_link follows the modified interface.
Thanks,
Jake
Hi,
Digging into this, the problem is complicated. The original bug assumed behavior
of the .check_for_link call, which is universally not implemented.
I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate signaling for
link check/link up", 2017-10-10) and find a more proper solution.
I don't think any other code which uses check_for_link expects the interface to
return in the way this patch attempted.
Alternatively, we can go a step farther and make sure every implementation of .check_for_link follows the modified interface.
From: Pavel Machek <hidden> Date: 2017-12-18 10:27:01
Hi!
quoted
quoted
quoted
In v4.15-rc2+, network manager can not see my ethernet card, and
manual attempts to ifconfig it up did not really help, either.
Card is:
02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet
Controller
I don't see the patch in latest mainline. Not having ethernet
is... somehow annoying. What is going on there?
Generally speaking, e1000 maintainence has been handled very poorly over
the past few years, I have to say.
Fixes take forever to propagate even when someone other than the
maintainer provides a working and tested fix, just like this case.
Jeff, please take e1000 maintainence seriously and get these critical
bug fixes propagated.
From: Paul Menzel <hidden> Date: 2017-12-21 09:41:00
Dear Pavel,
On 12/10/17 09:39, Pavel Machek wrote:
In v4.15-rc2+, network manager can not see my ethernet card, and manual attempts to ifconfig it up did not really help, either.
Card is:
02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit
Ethernet Controller
Dmesg says:
dmesg | grep eth
[ 0.648931] e1000e 0000:02:00.0 eth0: (PCI Express:2.5GT/s:Width x1) 00:16:d3:25:19:04
[ 0.648934] e1000e 0000:02:00.0 eth0: Intel(R) PRO/1000 Network Connection
[ 0.649012] e1000e 0000:02:00.0 eth0: MAC: 2, PHY: 2, PBA No: 005302-003
[ 0.706510] usbcore: registered new interface driver cdc_ether
[ 6.557022] e1000e 0000:02:00.0 eth1: renamed from eth0
[ 6.577554] systemd-udevd[2363]: renamed network interface eth0 to eth1
Any ideas?
I am sorry for jumping in on this so late.
Since using a Lenovo X60t more ofter since a year or so, I experience the issue, that the link doesn’t come up during that period occasionally [1]. I haven’t tried the latest patches yet, but it might be unrelated.
Did you test, that removing and loading the e1000e module fixes the issue?
Additionally, I was asked privately to test the out of tree driver, but haven’t had time yet.