[patch net-next] net: sched: don't set extack message in case the qdisc will be created

Subsystems: networking [general], tc subsystem, the rest

STALE3219d

2 messages, 2 authors, 2017-12-28 · open the first message on its own page

[patch net-next] net: sched: don't set extack message in case the qdisc will be created

From: Jiri Pirko <jiri@resnulli.us>
Date: 2017-12-28 15:52:12

From: Jiri Pirko <redacted>

If the qdisc is not found here, it is going to be created. Therefore,
this is not an error path. Remove the extack message set and don't
confuse user with error message in case the qdisc was created
successfully.

Fixes: 09215598119e ("net: sched: sch_api: handle generic qdisc errors")
Signed-off-by: Jiri Pirko <redacted>
---
 net/sched/sch_api.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index 3a3a1da..81ecf5b 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -1402,10 +1402,8 @@ static int tc_modify_qdisc(struct sk_buff *skb, struct nlmsghdr *n,
 					return -EINVAL;
 				}
 				q = qdisc_lookup(dev, tcm->tcm_handle);
-				if (!q) {
-					NL_SET_ERR_MSG(extack, "No qdisc found for specified handle");
+				if (!q)
 					goto create_n_graft;
-				}
 				if (n->nlmsg_flags & NLM_F_EXCL) {
 					NL_SET_ERR_MSG(extack, "Exclusivity flag on, cannot override");
 					return -EEXIST;
-- 
2.9.5

Re: [patch net-next] net: sched: don't set extack message in case the qdisc will be created

From: David Miller <davem@davemloft.net>
Date: 2017-12-28 17:18:48

From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 28 Dec 2017 16:52:10 +0100
From: Jiri Pirko <redacted>

If the qdisc is not found here, it is going to be created. Therefore,
this is not an error path. Remove the extack message set and don't
confuse user with error message in case the qdisc was created
successfully.

Fixes: 09215598119e ("net: sched: sch_api: handle generic qdisc errors")
Signed-off-by: Jiri Pirko <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help