# RE: \[PATCH V11 4/5\] vsprintf: add printk specifier %px

- From: Roberts, William C \<hidden\>
- Date: 2017-11-29 22:36:32 
- List: netdev
- Page: https://ratatoskr.run/netdev/2017/11/5144918
- Thread: https://ratatoskr.run/netdev/2017/11/5143751/t.md

```text


> -----Original Message-----
> From: <redacted> [mailto:<redacted>] On Behalf Of Kees
> Cook
> Sent: Wednesday, November 29, 2017 2:28 PM
> To: David Laight <redacted>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>; Tobin C. Harding
> [ref]; kernel-hardening@lists.openwall.com; Jason A. Donenfeld
> [ref]; Theodore Ts'o [ref]; Paolo Bonzini
> [ref]; Tycho Andersen [ref]; Roberts, William C
> [ref]; Tejun Heo [ref]; Jordan Glover
> [ref]; Greg KH [ref];
> Petr Mladek [ref]; Joe Perches [ref]; Ian
> Campbell [ref]; Sergey Senozhatsky
> [ref]; Catalin Marinas [ref];
> Will Deacon [ref]; Steven Rostedt [ref];
> Chris Fries [ref]; Dave Weinstein [ref]; Daniel
> Micay [ref]; Djalal Harouni [ref]; Radim
> Krcmár [ref]; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>; Network Development [ref];
> David Miller [ref]; Stephen Rothwell
> [ref]; Andrey Ryabinin [ref];
> Alexander Potapenko [ref]; Dmitry Vyukov
> [ref]; Andrew Morton [ref]
> Subject: Re: [PATCH V11 4/5] vsprintf: add printk specifier %px
> 
> On Wed, Nov 29, 2017 at 2:07 AM, David Laight [ref]
> wrote:
> > From: Linus Torvalds
> >> Sent: 29 November 2017 02:29
> >>
> >> On Tue, Nov 28, 2017 at 6:05 PM, Tobin C. Harding [ref] wrote:
> >> >
> >> >    Let's add specifier %px as a
> >> > clear, opt-in, way to print a pointer and maintain some level of
> >> > isolation from all the other hex integer output within the Kernel.
> >>
> >> Yes, I like this model. It's easy and it's obvious ("'x' for hex"),
> >> and it gives people a good way to say "yes, I really want the actual
> >> address as hex" for if/when the hashed pointer doesn't work for some
> >> reason.
> >
> > Remind me to change every %p to %px on kernels that support it.
> >
> > Although the absolute values of pointers may not be useful, knowing
> > that two pointer differ by a small amount is useful.
> > It is also useful to know whether pointers are to stack, code, static
> > data or heap.
> >
> > This change to %p is going to make debugging a nightmare.
> 
> In the future, maybe we could have a knob: unhashed, hashed (default), or
> zeroed.

Isn't that just kptr_restrict and get us right back to the simpler patches I proposed?

> 
> -Kees
> 
> --
> Kees Cook
> Pixel Security
```
