[PATCH ipsec] xfrm: fix XFRMA_OUTPUT_MARK policy entry

Subsystems: networking [general], networking [ipsec], the rest

STALE3208d

2 messages, 2 authors, 2017-12-01 · open the first message on its own page

[PATCH ipsec] xfrm: fix XFRMA_OUTPUT_MARK policy entry

From: Michal Kubecek <hidden>
Date: 2017-11-29 17:25:03

This seems to be an obvious typo, NLA_U32 is type of the attribute, not its
(minimal) length.

Fixes: 077fbac405bf ("net: xfrm: support setting an output mark.")
Signed-off-by: Michal Kubecek <redacted>
---
 net/xfrm/xfrm_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
index c2cfcc6fdb34..ff58c37469d6 100644
--- a/net/xfrm/xfrm_user.c
+++ b/net/xfrm/xfrm_user.c
@@ -2485,7 +2485,7 @@ static const struct nla_policy xfrma_policy[XFRMA_MAX+1] = {
 	[XFRMA_PROTO]		= { .type = NLA_U8 },
 	[XFRMA_ADDRESS_FILTER]	= { .len = sizeof(struct xfrm_address_filter) },
 	[XFRMA_OFFLOAD_DEV]	= { .len = sizeof(struct xfrm_user_offload) },
-	[XFRMA_OUTPUT_MARK]	= { .len = NLA_U32 },
+	[XFRMA_OUTPUT_MARK]	= { .type = NLA_U32 },
 };
 
 static const struct nla_policy xfrma_spd_policy[XFRMA_SPD_MAX+1] = {
-- 
2.15.0

Re: [PATCH ipsec] xfrm: fix XFRMA_OUTPUT_MARK policy entry

From: Steffen Klassert <steffen.klassert@secunet.com>
Date: 2017-12-01 06:00:27

On Wed, Nov 29, 2017 at 06:23:56PM +0100, Michal Kubecek wrote:
This seems to be an obvious typo, NLA_U32 is type of the attribute, not its
(minimal) length.

Fixes: 077fbac405bf ("net: xfrm: support setting an output mark.")
Signed-off-by: Michal Kubecek <redacted>
Patch applied, thanks Michal!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help