# Re: \[PATCH V11 2/5\] vsprintf: refactor %pK code out of pointer()

- From: Steven Rostedt \<rostedt@goodmis.org\>
- Date: 2017-11-29 02:40:03 
- List: netdev
- Page: https://ratatoskr.run/netdev/2017/11/5143763
- Thread: https://ratatoskr.run/netdev/2017/11/5143751/t.md

```text
On Wed, 29 Nov 2017 13:05:02 +1100
"Tobin C. Harding" [ref] wrote:

> +		/*
> +		 * kptr_restrict==1 cannot be used in IRQ context
> +		 * because its test for CAP_SYSLOG would be meaningless.
> +		 */
> +		if (in_irq() || in_serving_softirq() || in_nmi())

This could be replaced with:

		if (!in_task())

Which is actually more efficient.

-- Steve

> +			return string(buf, end, "pK-error", spec);
```
