[PATCH] atm: firestream: use setup_timer instead of init_timer

Subsystems: atm, the rest

STALE3181d

2 messages, 2 authors, 2017-11-30 · open the first message on its own page

[PATCH] atm: firestream: use setup_timer instead of init_timer

From: Colin King <hidden>
Date: 2017-11-24 13:13:49

From: Colin Ian King <redacted>

Use setup_timer function instead of initializing timer with the
function and data fields.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/atm/firestream.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c
index 6b6368a56526..534001270be5 100644
--- a/drivers/atm/firestream.c
+++ b/drivers/atm/firestream.c
@@ -1885,9 +1885,7 @@ static int fs_init(struct fs_dev *dev)
 	}
 
 #ifdef FS_POLL_FREQ
-	init_timer (&dev->timer);
-	dev->timer.data = (unsigned long) dev;
-	dev->timer.function = fs_poll;
+	setup_timer(&dev->timer, fs_poll, (unsigned long)dev);
 	dev->timer.expires = jiffies + FS_POLL_FREQ;
 	add_timer (&dev->timer);
 #endif
-- 
2.14.1

Re: [PATCH] atm: firestream: use setup_timer instead of init_timer

From: David Miller <davem@davemloft.net>
Date: 2017-11-30 14:23:31

From: Colin King <redacted>
Date: Fri, 24 Nov 2017 13:13:45 +0000
From: Colin Ian King <redacted>

Use setup_timer function instead of initializing timer with the
function and data fields.

Signed-off-by: Colin Ian King <redacted>
Likewise about setup_timer() no longer existing.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help