Re: [RFC] hv_netvsc: safer orderly shutdown

2 messages, 2 authors, 2017-11-13 · open the first message on its own page

Re: [RFC] hv_netvsc: safer orderly shutdown

From: Vitaly Kuznetsov <vkuznets@redhat.com>
Date: 2017-11-13 10:57:46

Stephen Hemminger [off-list ref] writes:
The NAPI disable is already handled by rndis close.
Sorry, but I'm probably missing something: I can only see
netif_napi_del() call in netvsc_device_remove() but this happens much
later. And I don see us doing napi_disable() anywhere on the path.
But I'm probably missing something.

-- 
  Vitaly

Re: [RFC] hv_netvsc: safer orderly shutdown

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2017-11-13 17:22:59

On Mon, 13 Nov 2017 11:57:47 +0100
Vitaly Kuznetsov [off-list ref] wrote:
Stephen Hemminger [off-list ref] writes:
quoted
The NAPI disable is already handled by rndis close.  
Sorry, but I'm probably missing something: I can only see
netif_napi_del() call in netvsc_device_remove() but this happens much
later. And I don see us doing napi_disable() anywhere on the path.
But I'm probably missing something.
You need to keep NAPI running to handle transmit completions.
Disabling the Tx and Rx filter should keep spurious activity
away until the halt is done.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help