[PATCH] fsl/fman_port: mark expected switch fall-throughs

Subsystems: networking drivers, the rest

STALE3201d

2 messages, 2 authors, 2017-11-11 · open the first message on its own page

[PATCH] fsl/fman_port: mark expected switch fall-throughs

From: Gustavo A. R. Silva <hidden>
Date: 2017-11-08 17:57:22

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1397960
Signed-off-by: Gustavo A. R. Silva <redacted>
---
 drivers/net/ethernet/freescale/fman/fman_port.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/freescale/fman/fman_port.c b/drivers/net/ethernet/freescale/fman/fman_port.c
index 1789b20..6552d68 100644
--- a/drivers/net/ethernet/freescale/fman/fman_port.c
+++ b/drivers/net/ethernet/freescale/fman/fman_port.c
@@ -1339,8 +1339,10 @@ int fman_port_config(struct fman_port *port, struct fman_port_params *params)
 	switch (port->port_type) {
 	case FMAN_PORT_TYPE_RX:
 		set_rx_dflt_cfg(port, params);
+		/* fall through */
 	case FMAN_PORT_TYPE_TX:
 		set_tx_dflt_cfg(port, params, &port->dts_params);
+		/* fall through */
 	default:
 		set_dflt_cfg(port, params);
 	}
-- 
2.7.4

Re: [PATCH] fsl/fman_port: mark expected switch fall-throughs

From: David Miller <davem@davemloft.net>
Date: 2017-11-11 09:50:54

From: "Gustavo A. R. Silva" <redacted>
Date: Wed, 8 Nov 2017 11:57:13 -0600
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1397960
Signed-off-by: Gustavo A. R. Silva <redacted>
Applied to net-next.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help