[PATCH 1/1] net: ipv4: use BUG_ON instead of condition followed by BUG
DORMANTno replies
From: Jian Wang <hidden>
Date: 2017-11-13 03:19:33
Subsystem:
networking [general], networking [ipv4/ipv6], the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern, Ido Schimmel, Linus Torvalds
Signed-off-by: Jian Wang <redacted> --- net/ipv4/ip_output.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index e8e675b..1a53553 100644
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c@@ -769,8 +769,8 @@ int ip_do_fragment(struct net *net, struct sock *sk, struct sk_buff *skb, /* * Copy a block of the IP datagram. */ - if (skb_copy_bits(skb, ptr, skb_transport_header(skb2), len)) - BUG(); + BUG_ON(skb_copy_bits(skb, ptr, skb_transport_header(skb2), len)); + left -= len; /*
--
2.7.4