[PATCH net] net: fix incorrect comment with regard to VLAN packet handling

Subsystems: networking drivers, networking [general], the rest

STALE3202d

2 messages, 2 authors, 2017-11-10 · open the first message on its own page

[PATCH net] net: fix incorrect comment with regard to VLAN packet handling

From: Girish Moodalbail <hidden>
Date: 2017-11-07 19:56:30

The commit bcc6d4790361 ("net: vlan: make non-hw-accel rx path similar
to hw-accel") unified accel and non-accel path for VLAN RX. With that
fix we do not register any packet_type handler for VLANs anymore, so fix
the incorrect comment.

Signed-off-by: Girish Moodalbail <redacted>
---
 include/linux/netdevice.h | 8 --------
 1 file changed, 8 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 2eaac7d..7098978 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -4411,15 +4411,7 @@ void netdev_printk(const char *level, const struct net_device *dev,
  *	Why 16. Because with 16 the only overlap we get on a hash of the
  *	low nibble of the protocol value is RARP/SNAP/X.25.
  *
- *      NOTE:  That is no longer true with the addition of VLAN tags.  Not
- *             sure which should go first, but I bet it won't make much
- *             difference if we are running VLANs.  The good news is that
- *             this protocol won't be in the list unless compiled in, so
- *             the average user (w/out VLANs) will not be adversely affected.
- *             --BLG
- *
  *		0800	IP
- *		8100    802.1Q VLAN
  *		0001	802.3
  *		0002	AX.25
  *		0004	802.2
-- 
1.8.3.1

Re: [PATCH net] net: fix incorrect comment with regard to VLAN packet handling

From: David Miller <davem@davemloft.net>
Date: 2017-11-10 09:05:01

From: Girish Moodalbail <redacted>
Date: Tue,  7 Nov 2017 11:32:11 -0800
The commit bcc6d4790361 ("net: vlan: make non-hw-accel rx path similar
to hw-accel") unified accel and non-accel path for VLAN RX. With that
fix we do not register any packet_type handler for VLANs anymore, so fix
the incorrect comment.

Signed-off-by: Girish Moodalbail <redacted>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help