[PATCH] rds: ib: Fix uninitialized variable

Subsystems: networking [general], rds - reliable datagram sockets, the rest

STALE3250d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2017-10-26 · open the first message on its own page

[PATCH] rds: ib: Fix uninitialized variable

From: Håkon Bugge <hidden>
Date: 2017-10-24 16:17:35

send_flags needs to be initialized before calling
rds_ib_set_wr_signal_state().

Signed-off-by: Håkon Bugge <redacted>
Acked-by: Santosh Shilimkar <redacted>
---
 net/rds/ib_send.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c
index 6ab39db..8f46755 100644
--- a/net/rds/ib_send.c
+++ b/net/rds/ib_send.c
@@ -792,6 +792,7 @@ int rds_ib_xmit_atomic(struct rds_connection *conn, struct rm_atomic_op *op)
 		send->s_atomic_wr.compare_add_mask = op->op_m_fadd.nocarry_mask;
 		send->s_atomic_wr.swap_mask = 0;
 	}
+	send->s_wr.send_flags = 0;
 	nr_sig = rds_ib_set_wr_signal_state(ic, send, op->op_notify);
 	send->s_atomic_wr.wr.num_sge = 1;
 	send->s_atomic_wr.wr.next = NULL;
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] rds: ib: Fix uninitialized variable

From: David Miller <davem@davemloft.net>
Date: 2017-10-26 08:36:43

From: Håkon Bugge <redacted>
Date: Tue, 24 Oct 2017 18:17:18 +0200
send_flags needs to be initialized before calling
rds_ib_set_wr_signal_state().

Signed-off-by: Håkon Bugge <redacted>
Acked-by: Santosh Shilimkar <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help