[PATCH] netfilter: ip6_tables: remove redundant assignment to e

Subsystems: networking [general], the rest

STALE3198d

2 messages, 2 authors, 2017-11-06 · open the first message on its own page

[PATCH] netfilter: ip6_tables: remove redundant assignment to e

From: Colin King <hidden>
Date: 2017-10-17 12:02:18

From: Colin Ian King <redacted>

The assignment to variable e is redundant since the same assignment
occurs just a few lines later, hence it can be removed.  Cleans up
clang warning: warning: Value stored to 'e' is never read

Signed-off-by: Colin Ian King <redacted>
---
 net/ipv6/netfilter/ip6_tables.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c
index 01bd3ee5ebc6..702e483d38b0 100644
--- a/net/ipv6/netfilter/ip6_tables.c
+++ b/net/ipv6/netfilter/ip6_tables.c
@@ -458,7 +458,6 @@ mark_source_chains(const struct xt_table_info *newinfo,
 					if (!xt_find_jump_offset(offsets, newpos,
 								 newinfo->number))
 						return 0;
-					e = entry0 + newpos;
 				} else {
 					/* ... this is a fallthru */
 					newpos = pos + e->next_offset;
-- 
2.14.1

Re: [PATCH] netfilter: ip6_tables: remove redundant assignment to e

From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2017-11-06 13:19:06

On Tue, Oct 17, 2017 at 01:02:00PM +0100, Colin King wrote:
From: Colin Ian King <redacted>

The assignment to variable e is redundant since the same assignment
occurs just a few lines later, hence it can be removed.  Cleans up
clang warning: warning: Value stored to 'e' is never read
Seems like net/ipv4/netfilter/ip_tables.c also has exactly the same
redundant assignment, see mark_source_chains() there.

If we can fix this all iptables spots in one go, the best. Please,
also check arp_tables and ebtables.

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help