[PATCH net-next v4 0/3] Completed requested changes

STALE3204d REVIEWED: 3 (2M)

Revision v4 of 4 in this series; 2 review trailers.

2 messages, 2 authors, 2017-11-01 · open the first message on its own page

[PATCH net-next v4 0/3] Completed requested changes

From: Manish Kurup <hidden>
Date: 2017-10-31 18:14:39

Hi everyone,

Modified the netronome drivers (flower action) to use the VLAN helper functions
instead of dereferencing the structure directly. This is required for the VLAN
action patch.

Could you please review?

Here're the changes:
v2: Fixed all helper functions to use RCU (rtnl_dereference) - Eric, Jamal
v2: Fixed indentation, extra line nits - Jamal, Jiri
v2: Moved rcu_head to the end of the struct - Jiri
v2: Re-formatted locals to reverse-christmas-tree - Jiri
v2: Removed mismatched spin_lock() - Cong
v2: Removed spin_lock_bh() in tcf_vlan_init, rtnl_dereference() should
    suffice - Cong, Jiri
v4: Modified the nfp flower action code to use the VLAN helper functions
    instead of referencing the structure directly. Isolated this into a
    separate patch - Pieter Jansen

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Acked-by: Jiri Pirko <redacted>
Signed-off-by: Manish Kurup <redacted>

Manish Kurup (3):
  net sched act_vlan: Change stats update to use per-core stats
  drivers net ethernet netronome nfp flower: netronome nfp flower action
  net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and
    update

 drivers/net/ethernet/netronome/nfp/flower/action.c |  5 +-
 include/net/tc_act/tc_vlan.h                       | 46 +++++++++++---
 net/sched/act_vlan.c                               | 71 ++++++++++++++--------
 3 files changed, 84 insertions(+), 38 deletions(-)

-- 
2.7.4

Re: [PATCH net-next v4 0/3] Completed requested changes

From: David Miller <davem@davemloft.net>
Date: 2017-11-01 02:02:27

From: Manish Kurup <redacted>
Date: Tue, 31 Oct 2017 14:14:28 -0400
Modified the netronome drivers (flower action) to use the VLAN helper functions
instead of dereferencing the structure directly. This is required for the VLAN
action patch.

Could you please review?
Please simplify the subsystem prefixes in your Subject lines, they are
very long.

"act_vlan: " and "nfp: " are more than sufficient.

Thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help