[patch net-next 0/2] mlxsw: Fixlets

STALE3233d

4 messages, 2 authors, 2017-10-02 · open the first message on its own page

[patch net-next 0/2] mlxsw: Fixlets

From: Jiri Pirko <jiri@resnulli.us>
Date: 2017-10-02 10:22:00

From: Jiri Pirko <redacted>

Couple of small nit fixes from Petr

Petr Machata (2):
  mlxsw: spectrum_router: Fix a typo
  mlxsw: spectrum_router: Drop a redundant condition

 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.9.5

[patch net-next 1/2] mlxsw: spectrum_router: Fix a typo

From: Jiri Pirko <jiri@resnulli.us>
Date: 2017-10-02 10:22:01

From: Petr Machata <redacted>

Signed-off-by: Petr Machata <redacted>
Signed-off-by: Jiri Pirko <redacted>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
index ef4b86b..75078a3 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
@@ -1680,7 +1680,7 @@ __mlxsw_sp_router_neighs_update_rauhtd(struct mlxsw_sp *mlxsw_sp,
 		err = mlxsw_reg_query(mlxsw_sp->core, MLXSW_REG(rauhtd),
 				      rauhtd_pl);
 		if (err) {
-			dev_err_ratelimited(mlxsw_sp->bus_info->dev, "Failed to dump neighbour talbe\n");
+			dev_err_ratelimited(mlxsw_sp->bus_info->dev, "Failed to dump neighbour table\n");
 			break;
 		}
 		num_rec = mlxsw_reg_rauhtd_num_rec_get(rauhtd_pl);
-- 
2.9.5

[patch net-next 2/2] mlxsw: spectrum_router: Drop a redundant condition

From: Jiri Pirko <jiri@resnulli.us>
Date: 2017-10-02 10:22:02

From: Petr Machata <redacted>

Signed-off-by: Petr Machata <redacted>
Reviewed-by: Ido Schimmel <redacted>
Signed-off-by: Jiri Pirko <redacted>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
index 75078a3..58bc04c 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
@@ -3251,7 +3251,7 @@ mlxsw_sp_fib_entry_offload_refresh(struct mlxsw_sp_fib_entry *fib_entry,
 			return;
 		if (mlxsw_sp_fib_entry_should_offload(fib_entry))
 			mlxsw_sp_fib_entry_offload_set(fib_entry);
-		else if (!mlxsw_sp_fib_entry_should_offload(fib_entry))
+		else
 			mlxsw_sp_fib_entry_offload_unset(fib_entry);
 		return;
 	default:
-- 
2.9.5

Re: [patch net-next 0/2] mlxsw: Fixlets

From: David Miller <davem@davemloft.net>
Date: 2017-10-02 18:20:56

From: Jiri Pirko <jiri@resnulli.us>
Date: Mon,  2 Oct 2017 12:21:56 +0200
From: Jiri Pirko <redacted>

Couple of small nit fixes from Petr
Series applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help