[PATCH][net-next] net: ipmr: make function ipmr_notifier_init static

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE3259d

2 messages, 2 authors, 2017-10-01 · open the first message on its own page

[PATCH][net-next] net: ipmr: make function ipmr_notifier_init static

From: Colin King <hidden>
Date: 2017-09-29 13:34:33

From: Colin Ian King <redacted>

The function ipmr_notifier_init is local to the source and does
not need to be in global scope, so make it static.

Cleans up sparse warning:
warning: symbol 'ipmr_notifier_init' was not declared. Should it be static?

Signed-off-by: Colin Ian King <redacted>
---
 net/ipv4/ipmr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c
index 292a8e80bdfa..a844738b38bd 100644
--- a/net/ipv4/ipmr.c
+++ b/net/ipv4/ipmr.c
@@ -3224,7 +3224,7 @@ static const struct fib_notifier_ops ipmr_notifier_ops_template = {
 	.owner		= THIS_MODULE,
 };
 
-int __net_init ipmr_notifier_init(struct net *net)
+static int __net_init ipmr_notifier_init(struct net *net)
 {
 	struct fib_notifier_ops *ops;
 
-- 
2.14.1

Re: [PATCH][net-next] net: ipmr: make function ipmr_notifier_init static

From: David Miller <davem@davemloft.net>
Date: 2017-10-01 03:07:25

From: Colin King <redacted>
Date: Fri, 29 Sep 2017 14:34:22 +0100
From: Colin Ian King <redacted>

The function ipmr_notifier_init is local to the source and does
not need to be in global scope, so make it static.

Cleans up sparse warning:
warning: symbol 'ipmr_notifier_init' was not declared. Should it be static?

Signed-off-by: Colin Ian King <redacted>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help