[PATCH] mkiss: remove redundant check on len being zero

Subsystems: networking drivers, the rest

STALE3267d

2 messages, 2 authors, 2017-09-30 · open the first message on its own page

[PATCH] mkiss: remove redundant check on len being zero

From: Colin King <hidden>
Date: 2017-09-27 21:45:25

From: Colin Ian King <redacted>

The check on len is redundant as it is always greater than 1,
so just remove it and make the printk less complex.

Detected by CoverityScan, CID#1226729 ("Logically dead code")

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/hamradio/mkiss.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c
index aec6c26563cf..54bf8e6e4a09 100644
--- a/drivers/net/hamradio/mkiss.c
+++ b/drivers/net/hamradio/mkiss.c
@@ -477,7 +477,8 @@ static void ax_encaps(struct net_device *dev, unsigned char *icp, int len)
 				  cmd = 0;
 				}
 				ax->crcauto = (cmd ? 0 : 1);
-				printk(KERN_INFO "mkiss: %s: crc mode %s %d\n", ax->dev->name, (len) ? "set to" : "is", cmd);
+				printk(KERN_INFO "mkiss: %s: crc mode set to %d\n",
+				       ax->dev->name, cmd);
 			}
 			spin_unlock_bh(&ax->buflock);
 			netif_start_queue(dev);
-- 
2.14.1

Re: [PATCH] mkiss: remove redundant check on len being zero

From: David Miller <davem@davemloft.net>
Date: 2017-09-30 04:44:58

From: Colin King <redacted>
Date: Wed, 27 Sep 2017 22:45:13 +0100
From: Colin Ian King <redacted>

The check on len is redundant as it is always greater than 1,
so just remove it and make the printk less complex.

Detected by CoverityScan, CID#1226729 ("Logically dead code")

Signed-off-by: Colin Ian King <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help