[PATCH net-next] tcp: fix under-evaluated ssthresh in TCP Vegas

Subsystems: networking [general], networking [tcp], the rest

STALE3263d

2 messages, 2 authors, 2017-09-29 · open the first message on its own page

[PATCH net-next] tcp: fix under-evaluated ssthresh in TCP Vegas

From: Hoang Tran <hidden>
Date: 2017-09-27 16:33:20

With the commit 76174004a0f19785 (tcp: do not slow start when cwnd equals
ssthresh), the comparison to the reduced cwnd in tcp_vegas_ssthresh() would
under-evaluate the ssthresh.

Signed-off-by: Hoang Tran <redacted>
---
 net/ipv4/tcp_vegas.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_vegas.c b/net/ipv4/tcp_vegas.c
index 218cfcc..ee113ff 100644
--- a/net/ipv4/tcp_vegas.c
+++ b/net/ipv4/tcp_vegas.c
@@ -158,7 +158,7 @@ EXPORT_SYMBOL_GPL(tcp_vegas_cwnd_event);
 
 static inline u32 tcp_vegas_ssthresh(struct tcp_sock *tp)
 {
-	return  min(tp->snd_ssthresh, tp->snd_cwnd-1);
+	return  min(tp->snd_ssthresh, tp->snd_cwnd);
 }
 
 static void tcp_vegas_cong_avoid(struct sock *sk, u32 ack, u32 acked)
-- 
2.7.4

Re: [PATCH net-next] tcp: fix under-evaluated ssthresh in TCP Vegas

From: David Miller <davem@davemloft.net>
Date: 2017-09-29 08:12:03

From: Hoang Tran <redacted>
Date: Wed, 27 Sep 2017 18:30:58 +0200
With the commit 76174004a0f19785 (tcp: do not slow start when cwnd equals
ssthresh), the comparison to the reduced cwnd in tcp_vegas_ssthresh() would
under-evaluate the ssthresh.

Signed-off-by: Hoang Tran <redacted>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help