[PATCH][next] cxgb4: make function ch_flower_stats_cb, fixes warning

Subsystems: cxgb4 ethernet driver (cxgb4), networking drivers, the rest

STALE3262d

2 messages, 2 authors, 2017-09-28 · open the first message on its own page

[PATCH][next] cxgb4: make function ch_flower_stats_cb, fixes warning

From: Colin King <hidden>
Date: 2017-09-26 15:14:13

From: Colin Ian King <redacted>

The function ch_flower_stats_cb is local to the source and does not need
to be in global scope, so make it static.

Cleans up sparse warnings:
symbol 'ch_flower_stats_cb' was not declared. Should it be static?

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c
index a36bd66d2834..92a311767381 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c
@@ -366,7 +366,7 @@ int cxgb4_tc_flower_destroy(struct net_device *dev,
 	return ret;
 }
 
-void ch_flower_stats_cb(unsigned long data)
+static void ch_flower_stats_cb(unsigned long data)
 {
 	struct adapter *adap = (struct adapter *)data;
 	struct ch_tc_flower_entry *flower_entry;
-- 
2.14.1

Re: [PATCH][next] cxgb4: make function ch_flower_stats_cb, fixes warning

From: David Miller <davem@davemloft.net>
Date: 2017-09-28 17:22:35

From: Colin King <redacted>
Date: Tue, 26 Sep 2017 16:14:09 +0100
From: Colin Ian King <redacted>

The function ch_flower_stats_cb is local to the source and does not need
to be in global scope, so make it static.

Cleans up sparse warnings:
symbol 'ch_flower_stats_cb' was not declared. Should it be static?

Signed-off-by: Colin Ian King <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help