[PATCH net-next] hv_netvsc: Fix the real number of queues of non-vRSS cases

Subsystems: hyper-v/azure core and drivers, networking drivers, the rest

STALE3265d

3 messages, 3 authors, 2017-09-26 · open the first message on its own page

[PATCH net-next] hv_netvsc: Fix the real number of queues of non-vRSS cases

From: Haiyang Zhang <hidden>
Date: 2017-09-22 22:32:47

From: Haiyang Zhang <haiyangz@microsoft.com>

For older hosts without multi-channel (vRSS) support, and some error
cases, we still need to set the real number of queues to one.
This patch adds this missing setting.

Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug")
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
---
 drivers/net/hyperv/netvsc_drv.c | 6 ++++++
 1 file changed, 6 insertions(+)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index d4902ee5f260..68eac12fbf75 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -1929,6 +1929,12 @@ static int netvsc_probe(struct hv_device *dev,
 	/* We always need headroom for rndis header */
 	net->needed_headroom = RNDIS_AND_PPI_SIZE;
 
+	/* Initialize the number of queues to be 1, we may change it if more
+	 * channels are offered later.
+	 */
+	netif_set_real_num_tx_queues(net, 1);
+	netif_set_real_num_rx_queues(net, 1);
+
 	/* Notify the netvsc driver of the new device */
 	memset(&device_info, 0, sizeof(device_info));
 	device_info.ring_size = ring_size;
-- 
2.14.1

Re: [PATCH net-next] hv_netvsc: Fix the real number of queues of non-vRSS cases

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2017-09-25 10:38:28

On Fri, 22 Sep 2017 15:31:38 -0700
Haiyang Zhang [off-list ref] wrote:
From: Haiyang Zhang <haiyangz@microsoft.com>

For older hosts without multi-channel (vRSS) support, and some error
cases, we still need to set the real number of queues to one.
This patch adds this missing setting.

Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug")
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Yes, this should fix issues with WS2012.

Reviewed-by: Stephen Hemminger <redacted>

Re: [PATCH net-next] hv_netvsc: Fix the real number of queues of non-vRSS cases

From: David Miller <davem@davemloft.net>
Date: 2017-09-26 03:21:30

From: Haiyang Zhang <redacted>
Date: Fri, 22 Sep 2017 15:31:38 -0700
From: Haiyang Zhang <haiyangz@microsoft.com>

For older hosts without multi-channel (vRSS) support, and some error
cases, we still need to set the real number of queues to one.
This patch adds this missing setting.

Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug")
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help