[patch net-next] team: fall back to hash if table entry is empty

Subsystems: networking drivers, team driver, the rest

STALE3272d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2017-09-19 · open the first message on its own page

[patch net-next] team: fall back to hash if table entry is empty

From: Jim Hanko <hidden>
Date: 2017-09-19 18:34:07

If the hash to port mapping table does not have a valid port (i.e. when
a port goes down), fall back to the simple hashing mechanism to avoid
dropping packets.

Signed-off-by: Jim Hanko <redacted>
Acked-by: Jiri Pirko <redacted>
---
 drivers/net/team/team_mode_loadbalance.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/team/team_mode_loadbalance.c b/drivers/net/team/team_mode_loadbalance.c
index 1468ddf..a5ef970 100644
--- a/drivers/net/team/team_mode_loadbalance.c
+++ b/drivers/net/team/team_mode_loadbalance.c
@@ -137,7 +137,13 @@ static struct team_port *lb_htpm_select_tx_port(struct team *team,
 						struct sk_buff *skb,
 						unsigned char hash)
 {
-	return rcu_dereference_bh(LB_HTPM_PORT_BY_HASH(lb_priv, hash));
+	struct team_port *port;
+
+	port = rcu_dereference_bh(LB_HTPM_PORT_BY_HASH(lb_priv, hash));
+	if (likely(port))
+		return port;
+	/* If no valid port in the table, fall back to simple hash */
+	return lb_hash_select_tx_port(team, lb_priv, skb, hash);
 }
 
 struct lb_select_tx_port {
-- 
2.7.4

Re: [patch net-next] team: fall back to hash if table entry is empty

From: David Miller <davem@davemloft.net>
Date: 2017-09-19 23:19:20

From: Jim Hanko <redacted>
Date: Tue, 19 Sep 2017 11:33:39 -0700
If the hash to port mapping table does not have a valid port (i.e. when
a port goes down), fall back to the simple hashing mechanism to avoid
dropping packets.

Signed-off-by: Jim Hanko <redacted>
Acked-by: Jiri Pirko <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help