[PATCH] net: ethernet: ti: netcp_core: no need in netif_napi_del

Subsystems: networking drivers, the rest

STALE3283d

2 messages, 2 authors, 2017-09-09 · open the first message on its own page

[PATCH] net: ethernet: ti: netcp_core: no need in netif_napi_del

From: Ivan Khoronzhuk <hidden>
Date: 2017-09-07 15:33:58

Don't remove rx_napi specifically just before free_netdev(),
it's supposed to be done in it and is confusing w/o tx_napi deletion.

Signed-off-by: Ivan Khoronzhuk <redacted>
---
Based on net-next/master

 drivers/net/ethernet/ti/netcp_core.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c
index eb96a69..437d362 100644
--- a/drivers/net/ethernet/ti/netcp_core.c
+++ b/drivers/net/ethernet/ti/netcp_core.c
@@ -2145,7 +2145,6 @@ static void netcp_delete_interface(struct netcp_device *netcp_device,
 
 	of_node_put(netcp->node_interface);
 	unregister_netdev(ndev);
-	netif_napi_del(&netcp->rx_napi);
 	free_netdev(ndev);
 }
 
-- 
2.7.4

Re: [PATCH] net: ethernet: ti: netcp_core: no need in netif_napi_del

From: David Miller <davem@davemloft.net>
Date: 2017-09-09 03:54:08

From: Ivan Khoronzhuk <redacted>
Date: Thu,  7 Sep 2017 18:32:30 +0300
Don't remove rx_napi specifically just before free_netdev(),
it's supposed to be done in it and is confusing w/o tx_napi deletion.

Signed-off-by: Ivan Khoronzhuk <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help