[PATCH net-next] net: ipv4: remove fib_info arg to fib_check_nh

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE3263d

3 messages, 3 authors, 2017-10-01 · open the first message on its own page

[PATCH net-next] net: ipv4: remove fib_info arg to fib_check_nh

From: David Ahern <hidden>
Date: 2017-09-28 03:42:06

fib_check_nh does not use the fib_info arg; remove t.

Signed-off-by: David Ahern <redacted>
---
 net/ipv4/fib_semantics.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
index 57a5d48acee8..79989124607e 100644
--- a/net/ipv4/fib_semantics.c
+++ b/net/ipv4/fib_semantics.c
@@ -774,8 +774,8 @@ bool fib_metrics_match(struct fib_config *cfg, struct fib_info *fi)
  *					|
  *					|-> {local prefix} (terminal node)
  */
-static int fib_check_nh(struct fib_config *cfg, struct fib_info *fi,
-			struct fib_nh *nh, struct netlink_ext_ack *extack)
+static int fib_check_nh(struct fib_config *cfg, struct fib_nh *nh,
+			struct netlink_ext_ack *extack)
 {
 	int err = 0;
 	struct net *net;
@@ -1258,7 +1258,7 @@ struct fib_info *fib_create_info(struct fib_config *cfg,
 		int linkdown = 0;
 
 		change_nexthops(fi) {
-			err = fib_check_nh(cfg, fi, nexthop_nh, extack);
+			err = fib_check_nh(cfg, nexthop_nh, extack);
 			if (err != 0)
 				goto failure;
 			if (nexthop_nh->nh_flags & RTNH_F_LINKDOWN)
-- 
2.1.4

Re: [PATCH net-next] net: ipv4: remove fib_info arg to fib_check_nh

From: David Miller <davem@davemloft.net>
Date: 2017-09-29 11:15:33

From: David Ahern <redacted>
Date: Wed, 27 Sep 2017 20:41:59 -0700
fib_check_nh does not use the fib_info arg; remove t.

Signed-off-by: David Ahern <redacted>
Applied.

Re: [PATCH net-next] net: ipv4: remove fib_info arg to fib_check_nh

From: Sergei Shtylyov <hidden>
Date: 2017-10-01 10:44:36

Hello!

On 9/28/2017 6:41 AM, David Ahern wrote:
fib_check_nh does not use the fib_info arg; remove t.
    s/t/it/. :-)
Signed-off-by: David Ahern <redacted>
[...]

MBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help