[PATCH] Documentation: fix ascii art in networking docs

Subsystems: documentation, networking [general], the rest

STALE3276d

5 messages, 4 authors, 2017-09-16 · open the first message on its own page

[PATCH] Documentation: fix ascii art in networking docs

From: Pavel Machek <hidden>
Date: 2017-09-16 16:22:19

Fix ascii-art.

Signed-off-by: Pavel Machek <redacted>

---

Resent, because I did not get DaveM's address right.
diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt
index 5e40e1f..6309e90 100644
--- a/Documentation/networking/switchdev.txt
+++ b/Documentation/networking/switchdev.txt
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
                       sw1p1  +  sw1p3  +  sw1p5  +          eth1
                         +    |    +    |    +    |            +
                         |    |    |    |    |    |            |
-                     +--+----+----+----+-+--+----+---+  +-----+-----+
+                     +--+----+----+----+----+----+---+  +-----+-----+
                      |         Switch driver         |  |    mgmt   |
                      |        (this document)        |  |   driver  |
                      |                               |  |           |
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html



----- End forwarded message -----

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] Documentation: fix ascii art in networking docs

From: Andrew Lunn <andrew@lunn.ch>
Date: 2017-09-16 16:51:14

On Sat, Sep 16, 2017 at 06:22:17PM +0200, Pavel Machek wrote:
quoted hunk
Fix ascii-art.

Signed-off-by: Pavel Machek <redacted>

---

Resent, because I did not get DaveM's address right.
diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt
index 5e40e1f..6309e90 100644
--- a/Documentation/networking/switchdev.txt
+++ b/Documentation/networking/switchdev.txt
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
 ??????????????????????????????????????????????????????????????????sw1p1??? +  sw1p3  + ???sw1p5  +  ????????????????????????eth1
 ????????????????????????????????????????????????????????????????????????+????????????|????????????+????????????|????????????+????????????|????????????????????????????????????+
 ????????????????????????????????????????????????????????????????????????|????????????|????????????|????????????|????????????|????????????|????????????????????????????????????|
-???????????????????????????????????????????????????????????????+--+----+----+----+-+--+----+---+??????+-----+-----+
+???????????????????????????????????????????????????????????????+--+----+----+----+----+----+---+??????+-----+-----+
 ???????????????????????????????????????????????????????????????|???????????????????????????Switch???driver???????????????????????????|??????|????????????mgmt?????????|
 ???????????????????????????????????????????????????????????????|????????????????????????(this???document)????????????????????????|??????|?????????driver??????|
 ???????????????????????????????????????????????????????????????|?????????????????????????????????????????????????????????????????????????????????????????????|??????|?????????????????????????????????|
Hi Pavel

This is not very readable. Has the patch been mangled by your email?

   Andrew

Re: [PATCH] Documentation: fix ascii art in networking docs

From: Andreas Schwab <hidden>
Date: 2017-09-16 18:18:18

On Sep 16 2017, Pavel Machek [off-list ref] wrote:
quoted hunk
diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt
index 5e40e1f..6309e90 100644
--- a/Documentation/networking/switchdev.txt
+++ b/Documentation/networking/switchdev.txt
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
                       sw1p1  +  sw1p3  +  sw1p5  +          eth1
                         +    |    +    |    +    |            +
                         |    |    |    |    |    |            |
-                     +--+----+----+----+-+--+----+---+  +-----+-----+
+                     +--+----+----+----+----+----+---+  +-----+-----+
                      |         Switch driver         |  |    mgmt   |
                      |        (this document)        |  |   driver  |
                      |                               |  |           |
This is all mis-aligned.  How about replacing all the thin space
characters by normal spaces?

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [PATCH] Documentation: fix ascii art in networking docs

From: Pavel Machek <hidden>
Date: 2017-09-16 19:25:21

On Sat 2017-09-16 20:18:15, Andreas Schwab wrote:
On Sep 16 2017, Pavel Machek [off-list ref] wrote:
quoted
diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt
index 5e40e1f..6309e90 100644
--- a/Documentation/networking/switchdev.txt
+++ b/Documentation/networking/switchdev.txt
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
                       sw1p1  +  sw1p3  +  sw1p5  +          eth1
                         +    |    +    |    +    |            +
                         |    |    |    |    |    |            |
-                     +--+----+----+----+-+--+----+---+  +-----+-----+
+                     +--+----+----+----+----+----+---+  +-----+-----+
                      |         Switch driver         |  |    mgmt   |
                      |        (this document)        |  |   driver  |
                      |                               |  |           |
This is all mis-aligned.  How about replacing all the thin space
characters by normal spaces?
It looked perfectly ok to me, in emacs. If you see a problem, please
submit followup patch.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] Documentation: fix ascii art in networking docs

From: Randy Dunlap <rdunlap@infradead.org>
Date: 2017-09-16 19:47:56

On 09/16/17 11:18, Andreas Schwab wrote:
On Sep 16 2017, Pavel Machek [off-list ref] wrote:
quoted
diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt
index 5e40e1f..6309e90 100644
--- a/Documentation/networking/switchdev.txt
+++ b/Documentation/networking/switchdev.txt
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
                       sw1p1  +  sw1p3  +  sw1p5  +          eth1
                         +    |    +    |    +    |            +
                         |    |    |    |    |    |            |
-                     +--+----+----+----+-+--+----+---+  +-----+-----+
+                     +--+----+----+----+----+----+---+  +-----+-----+
                      |         Switch driver         |  |    mgmt   |
                      |        (this document)        |  |   driver  |
                      |                               |  |           |
This is all mis-aligned.  How about replacing all the thin space
characters by normal spaces?
Yes, there are lots of non-ASCII "spaces" in the ASCII art.  :(

-- 
~Randy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help