[PATCH net] ipv6: sr: remove duplicate routing header type check

Subsystems: networking [general], networking [srv6], the rest

STALE3280d

2 messages, 2 authors, 2017-09-11 · open the first message on its own page

[PATCH net] ipv6: sr: remove duplicate routing header type check

From: David Lebrun <hidden>
Date: 2017-09-10 13:21:27

From: David Lebrun <redacted>

As seg6_validate_srh() already checks that the Routing Header type is
correct, it is not necessary to do it again in get_srh().

Fixes: 5829d70b ("ipv6: sr: fix get_srh() to comply with IPv6 standard "RFC 8200")
Signed-off-by: David Lebrun <redacted>
---
 net/ipv6/seg6_local.c | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c
index 7ff54db..825b8e0 100644
--- a/net/ipv6/seg6_local.c
+++ b/net/ipv6/seg6_local.c
@@ -72,10 +72,6 @@ static struct ipv6_sr_hdr *get_srh(struct sk_buff *skb)
 
 	srh = (struct ipv6_sr_hdr *)(skb->data + srhoff);
 
-	/* make sure it's a Segment Routing header (Routing Type 4) */
-	if (srh->type != IPV6_SRCRT_TYPE_4)
-		return NULL;
-
 	len = (srh->hdrlen + 1) << 3;
 
 	if (!pskb_may_pull(skb, srhoff + len))
-- 
2.10.2

Re: [PATCH net] ipv6: sr: remove duplicate routing header type check

From: David Miller <davem@davemloft.net>
Date: 2017-09-11 21:34:25

From: David Lebrun <redacted>
Date: Sun, 10 Sep 2017 14:22:01 +0100
From: David Lebrun <redacted>

As seg6_validate_srh() already checks that the Routing Header type is
correct, it is not necessary to do it again in get_srh().

Fixes: 5829d70b ("ipv6: sr: fix get_srh() to comply with IPv6 standard "RFC 8200")
Signed-off-by: David Lebrun <redacted>
Applied thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help