RE: [PATCH] mwifiex: remove unnecessary call to memset
From: Xinming Hu <hidden>
Date: 2017-09-12 01:36:54
Also in:
linux-wireless
Hi Himanshu,
-----Original Message----- From: Himanshu Jha [mailto:himanshujha199640@gmail.com] Sent: 2017年9月11日 20:46 To: amitkarwar@gmail.com Cc: Nishant Sarmukadam <redacted>; Ganapathi Bhat [off-list ref]; Xinming Hu [off-list ref]; kvalo@codeaurora.org; linux-wireless@vger.kernel.org; netdev@vger.kernel.org; Himanshu Jha [off-list ref] Subject: [EXT] [PATCH] mwifiex: remove unnecessary call to memset External Email ---------------------------------------------------------------------- call to memset to assign 0 value immediately after allocating memory with kzalloc is unnecesaary as kzalloc allocates the memory filled with 0 value.
Looks find to me, Thanks. Regards, Simon
quoted hunk
Semantic patch used to resolve this issue: @@ expression e,e2; constant c; statement S; @@ e = kzalloc(e2, c); if(e == NULL) S - memset(e, 0, e2); Signed-off-by: Himanshu Jha <redacted> --- drivers/net/wireless/marvell/mwifiex/scan.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/net/wireless/marvell/mwifiex/scan.cb/drivers/net/wireless/marvell/mwifiex/scan.c index c9d41ed..8838b88 100644--- a/drivers/net/wireless/marvell/mwifiex/scan.c +++ b/drivers/net/wireless/marvell/mwifiex/scan.c@@ -1936,8 +1936,6 @@ mwifiex_active_scan_req_for_passive_chan(structmwifiex_private *priv) if (!user_scan_cfg) return -ENOMEM; - memset(user_scan_cfg, 0, sizeof(*user_scan_cfg)); - for (id = 0; id < MWIFIEX_USER_SCAN_CHAN_MAX; id++) { if (!priv->hidden_chan[id].chan_number) break; -- 2.7.4