[PATCH 3/3] lan78xx: Use default value loaded from EEPROM/OTP when resetting

Subsystems: networking drivers, the rest, usb lan78xx ethernet driver, usb networking drivers

STALE3288d

3 messages, 2 authors, 2017-09-08 · open the first message on its own page

[PATCH 3/3] lan78xx: Use default value loaded from EEPROM/OTP when resetting

From: <hidden>
Date: 2017-09-07 07:12:37

From: Nisar Sayed <redacted>

Use default value loaded from EEPROM/OTP when resetting

Signed-off-by: Nisar Sayed <redacted>
---
 drivers/net/usb/lan78xx.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 94ef943..8fd7c2f 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -2452,7 +2452,6 @@ static int lan78xx_reset(struct lan78xx_net *dev)
 	/* LAN7801 only has RGMII mode */
 	if (dev->chipid == ID_REV_CHIP_ID_7801_)
 		buf &= ~MAC_CR_GMII_EN_;
-	buf |= MAC_CR_AUTO_DUPLEX_ | MAC_CR_AUTO_SPEED_;
 	ret = lan78xx_write_reg(dev, MAC_CR, buf);
 
 	ret = lan78xx_read_reg(dev, MAC_TX, &buf);
-- 
1.9.1

Re: [PATCH 3/3] lan78xx: Use default value loaded from EEPROM/OTP when resetting

From: Andrew Lunn <andrew@lunn.ch>
Date: 2017-09-07 14:13:05

On Thu, Sep 07, 2017 at 07:11:50AM +0000, Nisar.Sayed@microchip.com wrote:
From: Nisar Sayed <redacted>

Use default value loaded from EEPROM/OTP when resetting
Hi Nisar

Subject: [PATCH 3/3]

Is this a fix for net, or further development for net-next?

Why do we want the default values?

    Andrew

RE: [PATCH 3/3] lan78xx: Use default value loaded from EEPROM/OTP when resetting

From: <hidden>
Date: 2017-09-08 09:12:33

On Thu, Sep 07, 2017 at 07:11:50AM +0000, Nisar.Sayed@microchip.com
wrote:
quoted
From: Nisar Sayed <redacted>

Use default value loaded from EEPROM/OTP when resetting
Hi Nisar

Subject: [PATCH 3/3]

Is this a fix for net, or further development for net-next?

Why do we want the default values?

    Andrew
Thanks Andrew,

Yes it is for "net", sorry missed to include it, will update in next version of submit.

These bits are "reset protected" and should not be modified and must use the
Must be configured from EEPROM only. Will update the description.

- Nisar
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help