[PATCH 0/3] constify dsa_switch_ops

STALE3340d

6 messages, 3 authors, 2017-08-24 · open the first message on its own page

[PATCH 0/3] constify dsa_switch_ops

From: Arvind Yadav <hidden>
Date: 2017-08-23 10:17:17

dsa_switch_ops are not supposed to change at runtime. All functions
working with dsa_switch_ops provided by <net/dsa.h> work with
const dsa_switch_ops. So mark the non-const structs as const.

Arvind Yadav (3):
  [PATCH 1/3] net: dsa: loop: constify dsa_switch_ops
  [PATCH 2/3] net: dsa: lan9303: constify dsa_switch_ops
  [PATCH 3/3] net: dsa: mt7530: constify dsa_switch_ops

 drivers/net/dsa/dsa_loop.c     | 2 +-
 drivers/net/dsa/lan9303-core.c | 2 +-
 drivers/net/dsa/mt7530.c       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

-- 
1.9.1

[PATCH 1/3] net: dsa: loop: constify dsa_switch_ops

From: Arvind Yadav <hidden>
Date: 2017-08-23 10:17:23

dsa_switch_ops are not supposed to change at runtime. All functions
working with dsa_switch_ops provided by <net/dsa.h> work with
const dsa_switch_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <redacted>
---
 drivers/net/dsa/dsa_loop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c
index fdd8f38..2418172 100644
--- a/drivers/net/dsa/dsa_loop.c
+++ b/drivers/net/dsa/dsa_loop.c
@@ -294,7 +294,7 @@ static int dsa_loop_port_vlan_dump(struct dsa_switch *ds, int port,
 	return err;
 }
 
-static struct dsa_switch_ops dsa_loop_driver = {
+static const struct dsa_switch_ops dsa_loop_driver = {
 	.get_tag_protocol	= dsa_loop_get_protocol,
 	.setup			= dsa_loop_setup,
 	.get_strings		= dsa_loop_get_strings,
-- 
1.9.1

[PATCH 3/3] net: dsa: mt7530: constify dsa_switch_ops

From: Arvind Yadav <hidden>
Date: 2017-08-23 10:17:27

dsa_switch_ops are not supposed to change at runtime. All functions
working with dsa_switch_ops provided by <net/dsa.h> work with
const dsa_switch_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <redacted>
---
 drivers/net/dsa/mt7530.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index 264b281..77ae576 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -1039,7 +1039,7 @@ static void mt7530_adjust_link(struct dsa_switch *ds, int port,
 	return 0;
 }
 
-static struct dsa_switch_ops mt7530_switch_ops = {
+static const struct dsa_switch_ops mt7530_switch_ops = {
 	.get_tag_protocol	= mtk_get_tag_protocol,
 	.setup			= mt7530_setup,
 	.get_strings		= mt7530_get_strings,
-- 
1.9.1

[PATCH 2/3] net: dsa: lan9303: constify dsa_switch_ops

From: Arvind Yadav <hidden>
Date: 2017-08-23 10:18:26

dsa_switch_ops are not supposed to change at runtime. All functions
working with dsa_switch_ops provided by <net/dsa.h> work with
const dsa_switch_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <redacted>
---
 drivers/net/dsa/lan9303-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
index cd76e61..d4820d2 100644
--- a/drivers/net/dsa/lan9303-core.c
+++ b/drivers/net/dsa/lan9303-core.c
@@ -780,7 +780,7 @@ static void lan9303_port_disable(struct dsa_switch *ds, int port,
 	}
 }
 
-static struct dsa_switch_ops lan9303_switch_ops = {
+static const struct dsa_switch_ops lan9303_switch_ops = {
 	.get_tag_protocol = lan9303_get_tag_protocol,
 	.setup = lan9303_setup,
 	.get_strings = lan9303_get_strings,
-- 
1.9.1

Re: [PATCH 0/3] constify dsa_switch_ops

From: Andrew Lunn <andrew@lunn.ch>
Date: 2017-08-23 12:46:01

On Wed, Aug 23, 2017 at 03:46:56PM +0530, Arvind Yadav wrote:
dsa_switch_ops are not supposed to change at runtime. All functions
working with dsa_switch_ops provided by <net/dsa.h> work with
const dsa_switch_ops. So mark the non-const structs as const.

Arvind Yadav (3):
  [PATCH 1/3] net: dsa: loop: constify dsa_switch_ops
  [PATCH 2/3] net: dsa: lan9303: constify dsa_switch_ops
  [PATCH 3/3] net: dsa: mt7530: constify dsa_switch_ops
For the whole series:

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH 0/3] constify dsa_switch_ops

From: David Miller <davem@davemloft.net>
Date: 2017-08-24 05:30:46

From: Andrew Lunn <andrew@lunn.ch>
Date: Wed, 23 Aug 2017 14:45:56 +0200
On Wed, Aug 23, 2017 at 03:46:56PM +0530, Arvind Yadav wrote:
quoted
dsa_switch_ops are not supposed to change at runtime. All functions
working with dsa_switch_ops provided by <net/dsa.h> work with
const dsa_switch_ops. So mark the non-const structs as const.

Arvind Yadav (3):
  [PATCH 1/3] net: dsa: loop: constify dsa_switch_ops
  [PATCH 2/3] net: dsa: lan9303: constify dsa_switch_ops
  [PATCH 3/3] net: dsa: mt7530: constify dsa_switch_ops
For the whole series:

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
None of these patches apply to net-next, things are const there
already.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help