[PATCH 3/4] net: sh_eth: constify platform_device_id

Subsystems: networking drivers, renesas superh ethernet driver, the rest

STALE3350d

2 messages, 2 authors, 2017-08-14 · open the first message on its own page

[PATCH 3/4] net: sh_eth: constify platform_device_id

From: Arvind Yadav <hidden>
Date: 2017-08-13 11:12:57

platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.

Signed-off-by: Arvind Yadav <redacted>
---
 drivers/net/ethernet/renesas/sh_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index d2dc0a8..d2e88a3 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -3402,7 +3402,7 @@ static const struct dev_pm_ops sh_eth_dev_pm_ops = {
 #define SH_ETH_PM_OPS NULL
 #endif
 
-static struct platform_device_id sh_eth_id_table[] = {
+static const struct platform_device_id sh_eth_id_table[] = {
 	{ "sh7619-ether", (kernel_ulong_t)&sh7619_data },
 	{ "sh771x-ether", (kernel_ulong_t)&sh771x_data },
 	{ "sh7724-ether", (kernel_ulong_t)&sh7724_data },
-- 
2.7.4

Re: [PATCH 3/4] net: sh_eth: constify platform_device_id

From: Sergei Shtylyov <hidden>
Date: 2017-08-14 11:42:05

Hello!

On 08/13/2017 02:12 PM, Arvind Yadav wrote:
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.

Signed-off-by: Arvind Yadav <redacted>
Acked-by: Sergei Shtylyov <redacted>

though it seems too late as DaveM has taken the series...

[...]

MBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help