[PATCH] rtlwifi: btcoex: make function btc8723b2ant_dac_swing static

Subsystems: realtek wireless driver (rtlwifi family), the rest

STALE3350d

2 messages, 1 author, 2017-08-12 · open the first message on its own page

[PATCH] rtlwifi: btcoex: make function btc8723b2ant_dac_swing static

From: Colin King <hidden>
Date: 2017-08-12 22:00:45

From: Colin Ian King <redacted>

The function btc8723b2ant_dac_swing  is local to the source and
does not need to be in global scope, so make it static.

Cleans up sparse warning:
symbol 'btc8723b2ant_dac_swing' was not declared. Should it be static?

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
index 31965f0ef69d..9d2ecfbc7b33 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
@@ -833,9 +833,9 @@ static void btc8723b2ant_set_sw_fulltime_dac_swing(struct btc_coexist *btcoex,
 		btc8723b2ant_set_dac_swing_reg(btcoex, 0x18);
 }
 
-void btc8723b2ant_dac_swing(struct btc_coexist *btcoexist,
-			    bool force_exec, bool dac_swing_on,
-			    u32 dac_swing_lvl)
+static void btc8723b2ant_dac_swing(struct btc_coexist *btcoexist,
+				   bool force_exec, bool dac_swing_on,
+				   u32 dac_swing_lvl)
 {
 	struct rtl_priv *rtlpriv = btcoexist->adapter;
 
-- 
2.11.0

NACK: [PATCH] rtlwifi: btcoex: make function btc8723b2ant_dac_swing static

From: Colin Ian King <hidden>
Date: 2017-08-12 22:02:59

On 12/08/17 23:00, Colin King wrote:
quoted hunk
From: Colin Ian King <redacted>

The function btc8723b2ant_dac_swing  is local to the source and
does not need to be in global scope, so make it static.

Cleans up sparse warning:
symbol 'btc8723b2ant_dac_swing' was not declared. Should it be static?

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
index 31965f0ef69d..9d2ecfbc7b33 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
@@ -833,9 +833,9 @@ static void btc8723b2ant_set_sw_fulltime_dac_swing(struct btc_coexist *btcoex,
 		btc8723b2ant_set_dac_swing_reg(btcoex, 0x18);
 }
 
-void btc8723b2ant_dac_swing(struct btc_coexist *btcoexist,
-			    bool force_exec, bool dac_swing_on,
-			    u32 dac_swing_lvl)
+static void btc8723b2ant_dac_swing(struct btc_coexist *btcoexist,
+				   bool force_exec, bool dac_swing_on,
+				   u32 dac_swing_lvl)
 {
 	struct rtl_priv *rtlpriv = btcoexist->adapter;
 
Sent out wrong patch. Please ignore.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help