[PATCH][next] Bluetooth: kfree tmp rather than an alias to it

Subsystems: bluetooth subsystem, the rest

STALE3352d

2 messages, 2 authors, 2017-08-11 · open the first message on its own page

[PATCH][next] Bluetooth: kfree tmp rather than an alias to it

From: Colin King <hidden>
Date: 2017-08-11 18:33:12

From: Colin Ian King <redacted>

While the kfree of dhkey_a is of the same address of tmp, it
probably is clearer and more human readable if tmp is kfree'd
rather than dhkey_a.

Detected by CoverityScan, CID#1448650 ("Free of address-of expression")
Signed-off-by: Colin Ian King <redacted>
---
 net/bluetooth/selftest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/selftest.c b/net/bluetooth/selftest.c
index ee92c925ecc5..34a1227f4391 100644
--- a/net/bluetooth/selftest.c
+++ b/net/bluetooth/selftest.c
@@ -164,7 +164,7 @@ static int __init test_ecdh_sample(const u8 priv_a[32], const u8 priv_b[32],
 		ret = -EINVAL;
 
 out:
-	kfree(dhkey_a);
+	kfree(tmp);
 	return ret;
 }
 
-- 
2.11.0

Re: [PATCH][next] Bluetooth: kfree tmp rather than an alias to it

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2017-08-11 19:20:31

Hi Colin,
While the kfree of dhkey_a is of the same address of tmp, it
probably is clearer and more human readable if tmp is kfree'd
rather than dhkey_a.

Detected by CoverityScan, CID#1448650 ("Free of address-of expression")
Signed-off-by: Colin Ian King <redacted>
---
net/bluetooth/selftest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help