[PATCH] fm10k: Fix misuse of net_ratelimit()

Subsystems: intel ethernet drivers, networking drivers, the rest

STALE3316d

2 messages, 2 authors, 2017-09-18 · open the first message on its own page

[PATCH] fm10k: Fix misuse of net_ratelimit()

From: Joe Perches <joe@perches.com>
Date: 2017-08-11 16:17:21

Correct the backward logic using !net_ratelimit()

Miscellanea:

o Add a blank line before the error return label

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/ethernet/intel/fm10k/fm10k_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c
index 9dffaba85ae6..489d8032e2f2 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c
@@ -806,9 +806,10 @@ static int fm10k_tso(struct fm10k_ring *tx_ring,
 	tx_desc->mss = cpu_to_le16(skb_shinfo(skb)->gso_size);
 
 	return 1;
+
 err_vxlan:
 	tx_ring->netdev->features &= ~NETIF_F_GSO_UDP_TUNNEL;
-	if (!net_ratelimit())
+	if (net_ratelimit())
 		netdev_err(tx_ring->netdev,
 			   "TSO requested for unsupported tunnel, disabling offload\n");
 	return -1;
-- 
2.10.0.rc2.1.g053435c

RE: [Intel-wired-lan] [PATCH] fm10k: Fix misuse of net_ratelimit()

From: Singh, Krishneil K <hidden>
Date: 2017-09-18 17:22:53

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf
Of Joe Perches
Sent: Friday, August 11, 2017 9:17 AM
To: Kirsher, Jeffrey T <redacted>
Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-
kernel@vger.kernel.org
Subject: [Intel-wired-lan] [PATCH] fm10k: Fix misuse of net_ratelimit()

Correct the backward logic using !net_ratelimit()

Miscellanea:

o Add a blank line before the error return label

Signed-off-by: Joe Perches <joe@perches.com>
---
Tested-by: Krishneil Singh  <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help