[PATCH] ATM-lanai: Delete an error message for a failed memory allocation in lanai_init_one()

DORMANTno replies

From: SF Markus Elfring <hidden>
Date: 2017-08-06 08:00:35
Also in: kernel-janitors, lkml
Subsystem: atm, the rest · Maintainers: Chas Williams, Linus Torvalds

From: Markus Elfring <redacted>
Date: Sun, 6 Aug 2017 09:42:52 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <redacted>
---
 drivers/atm/lanai.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/atm/lanai.c b/drivers/atm/lanai.c
index 2351dad78ff5..f4cb6c5870bf 100644
--- a/drivers/atm/lanai.c
+++ b/drivers/atm/lanai.c
@@ -2562,11 +2562,8 @@ static int lanai_init_one(struct pci_dev *pci,
 	int result;
 
 	lanai = kmalloc(sizeof(*lanai), GFP_KERNEL);
-	if (lanai == NULL) {
-		printk(KERN_ERR DEV_LABEL
-		       ": couldn't allocate dev_data structure!\n");
+	if (!lanai)
 		return -ENOMEM;
-	}
 
 	atmdev = atm_dev_register(DEV_LABEL, &pci->dev, &ops, -1, NULL);
 	if (atmdev == NULL) {
-- 
2.13.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help