[PATCH net-next] xen-netfront: be more drop monitor friendly

Subsystems: networking drivers, the rest, xen hypervisor interface

STALE3332d

2 messages, 2 authors, 2017-08-30 · open the first message on its own page

[PATCH net-next] xen-netfront: be more drop monitor friendly

From: Eric Dumazet <hidden>
Date: 2017-08-30 17:33:01

From: Eric Dumazet <redacted>

xennet_start_xmit() might copy skb with inappropriate layout
into a fresh one.

Old skb is freed, and at this point it is not a drop, but
a consume. New skb will then be either consumed or dropped. 

Signed-off-by: Eric Dumazet <redacted>
---
 drivers/net/xen-netfront.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 7b61adb6270c..523387e71a80 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -611,7 +611,7 @@ static int xennet_start_xmit(struct sk_buff *skb, struct net_device *dev)
 		nskb = skb_copy(skb, GFP_ATOMIC);
 		if (!nskb)
 			goto drop;
-		dev_kfree_skb_any(skb);
+		dev_consume_skb_any(skb);
 		skb = nskb;
 		page = virt_to_page(skb->data);
 		offset = offset_in_page(skb->data);

Re: [PATCH net-next] xen-netfront: be more drop monitor friendly

From: David Miller <davem@davemloft.net>
Date: 2017-08-30 23:01:39

From: Eric Dumazet <redacted>
Date: Wed, 30 Aug 2017 10:32:58 -0700
From: Eric Dumazet <redacted>

xennet_start_xmit() might copy skb with inappropriate layout
into a fresh one.

Old skb is freed, and at this point it is not a drop, but
a consume. New skb will then be either consumed or dropped. 

Signed-off-by: Eric Dumazet <redacted>
Applied, thanks Eric.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help