[net-next:master 1328/1341] drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:77:3: error: 'devlink_dpipe_header_ethernet' undeclared here (not in a function)

3 messages, 3 authors, 2017-08-25 · open the first message on its own page

[net-next:master 1328/1341] drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:77:3: error: 'devlink_dpipe_header_ethernet' undeclared here (not in a function)

From: kbuild test robot <hidden>
Date: 2017-08-25 00:16:11

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   39a7e5892418514db114ea4842d7d88aee6a61b8
commit: 6aecb36bc01fc9c84f24c4155e8850b6a1962f03 [1328/1341] mlxsw: spectrum_dpipe: Add IPv4 host table initial support
config: i386-randconfig-sb0-08250550 (attached as .config)
compiler: gcc-5 (Debian 5.4.1-2) 5.4.1 20160904
reproduce:
        git checkout 6aecb36bc01fc9c84f24c4155e8850b6a1962f03
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):
quoted
drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:77:3: error: 'devlink_dpipe_header_ethernet' undeclared here (not in a function)
     &devlink_dpipe_header_ethernet,
      ^
quoted
drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:78:3: error: 'devlink_dpipe_header_ipv4' undeclared here (not in a function)
     &devlink_dpipe_header_ipv4,
      ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c: In function 'mlxsw_sp_dpipe_erif_table_init':
   drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:305:9: error: too few arguments to function 'devlink_dpipe_table_register'
     return devlink_dpipe_table_register(devlink,
            ^
   In file included from drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:36:0:
   include/net/devlink.h:402:1: note: declared here
    devlink_dpipe_table_register(struct devlink *devlink,
    ^
quoted
drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:305:9: warning: return makes integer from pointer without a cast [-Wint-conversion]
     return devlink_dpipe_table_register(devlink,
            ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c: In function 'mlxsw_sp_dpipe_table_host_matches_dump':
quoted
drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:332:15: error: assignment from incompatible pointer type [-Werror=incompatible-pointer-types]
     match.header = &devlink_dpipe_header_ipv4;
                  ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c: In function 'mlxsw_sp_dpipe_table_host4_actions_dump':
   drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:350:16: error: assignment from incompatible pointer type [-Werror=incompatible-pointer-types]
     action.header = &devlink_dpipe_header_ethernet;
                   ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c: In function 'mlxsw_sp_dpipe_host4_table_init':
   drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:397:9: error: too few arguments to function 'devlink_dpipe_table_register'
     return devlink_dpipe_table_register(devlink,
            ^
   In file included from drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:36:0:
   include/net/devlink.h:402:1: note: declared here
    devlink_dpipe_table_register(struct devlink *devlink,
    ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:397:9: warning: return makes integer from pointer without a cast [-Wint-conversion]
     return devlink_dpipe_table_register(devlink,
            ^
   cc1: some warnings being treated as errors

vim +/devlink_dpipe_header_ethernet +77 drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c

  > 36	#include <net/devlink.h>
    37	
    38	#include "spectrum.h"
    39	#include "spectrum_dpipe.h"
    40	#include "spectrum_router.h"
    41	
    42	enum mlxsw_sp_field_metadata_id {
    43		MLXSW_SP_DPIPE_FIELD_METADATA_ERIF_PORT,
    44		MLXSW_SP_DPIPE_FIELD_METADATA_L3_FORWARD,
    45		MLXSW_SP_DPIPE_FIELD_METADATA_L3_DROP,
    46	};
    47	
    48	static struct devlink_dpipe_field mlxsw_sp_dpipe_fields_metadata[] = {
    49		{ .name = "erif_port",
    50		  .id = MLXSW_SP_DPIPE_FIELD_METADATA_ERIF_PORT,
    51		  .bitwidth = 32,
    52		  .mapping_type = DEVLINK_DPIPE_FIELD_MAPPING_TYPE_IFINDEX,
    53		},
    54		{ .name = "l3_forward",
    55		  .id = MLXSW_SP_DPIPE_FIELD_METADATA_L3_FORWARD,
    56		  .bitwidth = 1,
    57		},
    58		{ .name = "l3_drop",
    59		  .id = MLXSW_SP_DPIPE_FIELD_METADATA_L3_DROP,
    60		  .bitwidth = 1,
    61		},
    62	};
    63	
    64	enum mlxsw_sp_dpipe_header_id {
    65		MLXSW_SP_DPIPE_HEADER_METADATA,
    66	};
    67	
    68	static struct devlink_dpipe_header mlxsw_sp_dpipe_header_metadata = {
    69		.name = "mlxsw_meta",
    70		.id = MLXSW_SP_DPIPE_HEADER_METADATA,
    71		.fields = mlxsw_sp_dpipe_fields_metadata,
    72		.fields_count = ARRAY_SIZE(mlxsw_sp_dpipe_fields_metadata),
    73	};
    74	
    75	static struct devlink_dpipe_header *mlxsw_dpipe_headers[] = {
    76		&mlxsw_sp_dpipe_header_metadata,
  > 77		&devlink_dpipe_header_ethernet,
  > 78		&devlink_dpipe_header_ipv4,
    79	};
    80	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Re: [net-next:master 1328/1341] drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:77:3: error: 'devlink_dpipe_header_ethernet' undeclared here (not in a function)

From: David Miller <davem@davemloft.net>
Date: 2017-08-25 01:11:51

From: kbuild test robot <redacted>
Date: Fri, 25 Aug 2017 08:16:01 +0800
All error/warnings (new ones prefixed by >>):
quoted
quoted
drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:77:3: error: 'devlink_dpipe_header_ethernet' undeclared here (not in a function)
     &devlink_dpipe_header_ethernet,
      ^
quoted
quoted
drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:78:3: error: 'devlink_dpipe_header_ipv4' undeclared here (not in a function)
     &devlink_dpipe_header_ipv4,
      ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c: In function 'mlxsw_sp_dpipe_erif_table_init':
   drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:305:9: error: too few arguments to function 'devlink_dpipe_table_register'
     return devlink_dpipe_table_register(devlink,
Jiri and co., I think you'll need some ifdef'ery to deal with this
properly.

Re: [net-next:master 1328/1341] drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:77:3: error: 'devlink_dpipe_header_ethernet' undeclared here (not in a function)

From: Jiri Pirko <jiri@resnulli.us>
Date: 2017-08-25 07:28:26

Fri, Aug 25, 2017 at 03:11:50AM CEST, davem@davemloft.net wrote:
From: kbuild test robot <redacted>
Date: Fri, 25 Aug 2017 08:16:01 +0800
quoted
All error/warnings (new ones prefixed by >>):
quoted
quoted
drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:77:3: error: 'devlink_dpipe_header_ethernet' undeclared here (not in a function)
     &devlink_dpipe_header_ethernet,
      ^
quoted
quoted
drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:78:3: error: 'devlink_dpipe_header_ipv4' undeclared here (not in a function)
     &devlink_dpipe_header_ipv4,
      ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c: In function 'mlxsw_sp_dpipe_erif_table_init':
   drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:305:9: error: too few arguments to function 'devlink_dpipe_table_register'
     return devlink_dpipe_table_register(devlink,
Jiri and co., I think you'll need some ifdef'ery to deal with this
properly.
Will fix this. Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help