[PATCH net] virtio_net: be drop monitor friend

Subsystems: networking drivers, the rest, virtio net driver

STALE3338d

4 messages, 3 authors, 2017-08-24 · open the first message on its own page

[PATCH net] virtio_net: be drop monitor friend

From: Eric Dumazet <hidden>
Date: 2017-08-24 16:02:51

From: Eric Dumazet <redacted>

This change is needed to not fool drop monitor.
(perf record ... -e skb:kfree_skb )

Packets were properly sent and are consumed after TX completion.

Signed-off-by: Eric Dumazet <redacted>
---
 drivers/net/virtio_net.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 98f17b05c68b..b06169ea60dc 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1058,7 +1058,7 @@ static void free_old_xmit_skbs(struct send_queue *sq)
 		bytes += skb->len;
 		packets++;
 
-		dev_kfree_skb_any(skb);
+		dev_consume_skb_any(skb);
 	}
 
 	/* Avoid overhead when no packets have been processed

Re: [PATCH net] virtio_net: be drop monitor friend

From: David Miller <davem@davemloft.net>
Date: 2017-08-24 18:50:53

From: Eric Dumazet <redacted>
Date: Thu, 24 Aug 2017 09:02:49 -0700
From: Eric Dumazet <redacted>

This change is needed to not fool drop monitor.
(perf record ... -e skb:kfree_skb )

Packets were properly sent and are consumed after TX completion.

Signed-off-by: Eric Dumazet <redacted>
I'm pretty sure you meant "friendly" in the Subject line so I fixed
it up to say that :-)

Applied, thanks.

Re: [PATCH net] virtio_net: be drop monitor friend

From: Eric Dumazet <hidden>
Date: 2017-08-24 19:34:32

On Thu, 2017-08-24 at 11:50 -0700, David Miller wrote:
From: Eric Dumazet <redacted>
Date: Thu, 24 Aug 2017 09:02:49 -0700
quoted
From: Eric Dumazet <redacted>

This change is needed to not fool drop monitor.
(perf record ... -e skb:kfree_skb )

Packets were properly sent and are consumed after TX completion.

Signed-off-by: Eric Dumazet <redacted>
I'm pretty sure you meant "friendly" in the Subject line so I fixed
it up to say that :-)

Applied, thanks.
Ah, great, thanks for fixing this ;)

Re: [PATCH net] virtio_net: be drop monitor friend

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2017-08-24 21:43:01

On Thu, Aug 24, 2017 at 09:02:49AM -0700, Eric Dumazet wrote:
From: Eric Dumazet <redacted>

This change is needed to not fool drop monitor.
(perf record ... -e skb:kfree_skb )

Packets were properly sent and are consumed after TX completion.

Signed-off-by: Eric Dumazet <redacted>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
quoted hunk
---
 drivers/net/virtio_net.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 98f17b05c68b..b06169ea60dc 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1058,7 +1058,7 @@ static void free_old_xmit_skbs(struct send_queue *sq)
 		bytes += skb->len;
 		packets++;
 
-		dev_kfree_skb_any(skb);
+		dev_consume_skb_any(skb);
 	}
 
 	/* Avoid overhead when no packets have been processed
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help