Re: [PATCH net-next v5] openvswitch: enable NSH support

On Mon, 21 Aug 2017 13:54:23 +0800, Yi Yang wrote:

v4->v5
 - Fix many comments by Jiri Benc and Eric Garver
   for v4.

NACK for v5, we haven't finished discussing v4. You're sending new
versions too quickly.

My comment about sending a new version was meant only for the rest of
the patch that I have not reviewed - i.e. that once the comments I've
made so far are addressed, I'm fine with continuing reviewing in a new
version.

It did not mean that I'm okay with sending a new version without my
comments to the first part being addressed. Which they are not, see my
reply to your mail at v4.

Sorry if that was not clear but I won't review v5 until we have
conclusion for the v4 comments.

 Jiri

On Mon, Aug 21, 2017 at 10:25:09AM +0200, Jiri Benc wrote:

On Mon, 21 Aug 2017 13:54:23 +0800, Yi Yang wrote:

quoted

v4->v5
 - Fix many comments by Jiri Benc and Eric Garver
   for v4.

NACK for v5, we haven't finished discussing v4. You're sending new
versions too quickly.

My comment about sending a new version was meant only for the rest of
the patch that I have not reviewed - i.e. that once the comments I've
made so far are addressed, I'm fine with continuing reviewing in a new
version.

It did not mean that I'm okay with sending a new version without my
comments to the first part being addressed. Which they are not, see my
reply to your mail at v4.

Sorry if that was not clear but I won't review v5 until we have
conclusion for the v4 comments.

Ok, let me fix comments for v4 first.

 Jiri