[patch net-next] net: sched: cls_flower: fix ndo_setup_tc type for stats call

Subsystems: networking [general], tc subsystem, the rest

STALE3347d

2 messages, 2 authors, 2017-08-16 · open the first message on its own page

[patch net-next] net: sched: cls_flower: fix ndo_setup_tc type for stats call

From: Jiri Pirko <jiri@resnulli.us>
Date: 2017-08-16 15:15:22

From: Jiri Pirko <redacted>

I made a stupid mistake using TC_CLSFLOWER_STATS instead of
TC_SETUP_CLSFLOWER. Funny thing is that both are defined as "2" so it
actually did not cause any harm. Anyway, fixing it now.

Fixes: 2572ac53c46f ("net: sched: make type an argument for ndo_setup_tc")
Signed-off-by: Jiri Pirko <redacted>
---
 net/sched/cls_flower.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
index 052e902..bd9dab4 100644
--- a/net/sched/cls_flower.c
+++ b/net/sched/cls_flower.c
@@ -289,7 +289,7 @@ static void fl_hw_update_stats(struct tcf_proto *tp, struct cls_fl_filter *f)
 	cls_flower.cookie = (unsigned long) f;
 	cls_flower.exts = &f->exts;
 
-	dev->netdev_ops->ndo_setup_tc(dev, TC_CLSFLOWER_STATS,
+	dev->netdev_ops->ndo_setup_tc(dev, TC_SETUP_CLSFLOWER,
 				      &cls_flower);
 }
 
-- 
2.9.3

Re: [patch net-next] net: sched: cls_flower: fix ndo_setup_tc type for stats call

From: David Miller <davem@davemloft.net>
Date: 2017-08-16 21:30:08

From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 16 Aug 2017 17:15:18 +0200
From: Jiri Pirko <redacted>

I made a stupid mistake using TC_CLSFLOWER_STATS instead of
TC_SETUP_CLSFLOWER. Funny thing is that both are defined as "2" so it
actually did not cause any harm. Anyway, fixing it now.

Fixes: 2572ac53c46f ("net: sched: make type an argument for ndo_setup_tc")
Signed-off-by: Jiri Pirko <redacted>
Applied, thanks Jiri.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help