# Re: \[PATCH\] net\_sched: remove warning from qdisc\_hash\_add

- From: David Miller \<davem@davemloft.net\>
- Date: 2017-08-16 00:17:11 
- List: netdev
- Page: https://ratatoskr.run/netdev/2017/08/11062789
- Thread: https://ratatoskr.run/netdev/2017/08/11062687/t.md

```text
From: Konstantin Khlebnikov <redacted>
Date: Tue, 15 Aug 2017 16:39:05 +0300

> It was added in commit e57a784d8cae ("pkt_sched: set root qdisc
> before change() in attach_default_qdiscs()") to hide duplicates
> from "tc qdisc show" for incative deivices.
> 
> After 59cc1f61f ("net: sched: convert qdisc linked list to hashtable")
> it triggered when classful qdisc is added to inactive device because
> default qdiscs are added before switching root qdisc.
> 
> Anyway after commit ea3274695353 ("net: sched: avoid duplicates in
> qdisc dump") duplicates are filtered right in dumper.
> 
> Signed-off-by: Konstantin Khlebnikov <redacted>

Applied.
```