[PATCH net-next] net: skb_needs_check() removes CHECKSUM_UNNECESSARY check for tx.

Subsystems: networking [general], the rest

STALE3355d

3 messages, 3 authors, 2017-08-11 · open the first message on its own page

[PATCH net-next] net: skb_needs_check() removes CHECKSUM_UNNECESSARY check for tx.

From: Tonghao Zhang <hidden>
Date: 2017-08-11 03:16:56

Because we remove the UFO support, we will also remove the
CHECKSUM_UNNECESSARY check in skb_needs_check().

Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: Tonghao Zhang <redacted>
---
 net/core/dev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 3f69f6e..1024d37 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2731,8 +2731,7 @@ struct sk_buff *skb_mac_gso_segment(struct sk_buff *skb,
 static inline bool skb_needs_check(struct sk_buff *skb, bool tx_path)
 {
 	if (tx_path)
-		return skb->ip_summed != CHECKSUM_PARTIAL &&
-		       skb->ip_summed != CHECKSUM_UNNECESSARY;
+		return skb->ip_summed != CHECKSUM_PARTIAL;
 
 	return skb->ip_summed == CHECKSUM_NONE;
 }
-- 
1.8.3.1

Re: [PATCH net-next] net: skb_needs_check() removes CHECKSUM_UNNECESSARY check for tx.

From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: 2017-08-11 17:44:05

On Thu, Aug 10, 2017 at 8:16 PM, Tonghao Zhang [off-list ref] wrote:
Because we remove the UFO support, we will also remove the
CHECKSUM_UNNECESSARY check in skb_needs_check().

Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: Tonghao Zhang <redacted>
Acked-by: Willem de Bruijn <willemb@google.com>

Thanks for fixing up and resubmitting after the merge.

Re: [PATCH net-next] net: skb_needs_check() removes CHECKSUM_UNNECESSARY check for tx.

From: David Miller <davem@davemloft.net>
Date: 2017-08-11 21:46:10

From: Tonghao Zhang <redacted>
Date: Thu, 10 Aug 2017 20:16:29 -0700
Because we remove the UFO support, we will also remove the
CHECKSUM_UNNECESSARY check in skb_needs_check().

Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: Tonghao Zhang <redacted>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help