[PATCH net-next] net: ipv6: lower ndisc notifier priority below addrconf

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE3358d

2 messages, 2 authors, 2017-08-10 · open the first message on its own page

[PATCH net-next] net: ipv6: lower ndisc notifier priority below addrconf

From: David Ahern <hidden>
Date: 2017-08-08 21:51:08

ndisc_notify is used to send unsolicited neighbor advertisements
(e.g., on a link up). Currently, the ndisc notifier is run before the
addrconf notifer which means NA's are not sent for link-local addresses
which are added by the addrconf notifier.

Fix by lowering the priority of the ndisc notifier. Setting the priority
to ADDRCONF_NOTIFY_PRIORITY - 5 means it runs after addrconf and before
the route notifier which is ADDRCONF_NOTIFY_PRIORITY - 10.

Signed-off-by: David Ahern <redacted>
---
 net/ipv6/ndisc.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index 0327c1f2e6fc..5e338eb89509 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -1779,6 +1779,7 @@ static int ndisc_netdev_event(struct notifier_block *this, unsigned long event,
 
 static struct notifier_block ndisc_netdev_notifier = {
 	.notifier_call = ndisc_netdev_event,
+	.priority = ADDRCONF_NOTIFY_PRIORITY - 5,
 };
 
 #ifdef CONFIG_SYSCTL
-- 
2.9.3

Re: [PATCH net-next] net: ipv6: lower ndisc notifier priority below addrconf

From: David Miller <davem@davemloft.net>
Date: 2017-08-10 05:40:17

From: David Ahern <redacted>
Date: Tue,  8 Aug 2017 15:51:02 -0600
ndisc_notify is used to send unsolicited neighbor advertisements
(e.g., on a link up). Currently, the ndisc notifier is run before the
addrconf notifer which means NA's are not sent for link-local addresses
which are added by the addrconf notifier.

Fix by lowering the priority of the ndisc notifier. Setting the priority
to ADDRCONF_NOTIFY_PRIORITY - 5 means it runs after addrconf and before
the route notifier which is ADDRCONF_NOTIFY_PRIORITY - 10.

Signed-off-by: David Ahern <redacted>
Applied, thanks David.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help