[PATCH] ipv4: Introduce ipip_offload_init helper function.

Subsystems: networking [general], the rest

STALE3359d

2 messages, 2 authors, 2017-08-03 · open the first message on its own page

[PATCH] ipv4: Introduce ipip_offload_init helper function.

From: Tonghao Zhang <hidden>
Date: 2017-08-02 16:34:32

It's convenient to init ipip offload. We will check
the return value, and print KERN_CRIT info on failure.

Signed-off-by: Tonghao Zhang <redacted>
---
 net/ipv4/af_inet.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index 5ce44fb..c888120 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -1763,6 +1763,11 @@ static int __init init_inet_pernet_ops(void)
 	},
 };
 
+static int __init ipip_offload_init(void)
+{
+	return inet_add_offload(&ipip_offload, IPPROTO_IPIP);
+}
+
 static int __init ipv4_offload_init(void)
 {
 	/*
@@ -1772,9 +1777,10 @@ static int __init ipv4_offload_init(void)
 		pr_crit("%s: Cannot add UDP protocol offload\n", __func__);
 	if (tcpv4_offload_init() < 0)
 		pr_crit("%s: Cannot add TCP protocol offload\n", __func__);
+	if (ipip_offload_init() < 0)
+		pr_crit("%s: Cannot add IPIP protocol offload\n", __func__);
 
 	dev_add_offload(&ip_packet_offload);
-	inet_add_offload(&ipip_offload, IPPROTO_IPIP);
 	return 0;
 }
 
-- 
1.8.3.1

Re: [PATCH] ipv4: Introduce ipip_offload_init helper function.

From: David Miller <davem@davemloft.net>
Date: 2017-08-03 16:27:21

From: Tonghao Zhang <redacted>
Date: Wed,  2 Aug 2017 09:34:15 -0700
It's convenient to init ipip offload. We will check
the return value, and print KERN_CRIT info on failure.

Signed-off-by: Tonghao Zhang <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help