# Re: \[PATCH\] net/sctp/ulpevent.c: Deinline sctp\_ulpevent\_set\_owner, save 1616 bytes

- From: Joe Perches \<joe@perches.com\>
- Date: 2017-06-21 19:19:16 
- List: netdev
- Page: https://ratatoskr.run/netdev/2017/06/5026779
- Thread: https://ratatoskr.run/linux-sctp/2017/06/5026577/t.md

```text
On Wed, 2017-06-21 at 18:28 +0200, Denys Vlasenko wrote:
> This function compiles to 147 bytes of machine code. 13 callsites.
> 
> I'm no expert on SCTP events, but quick reading of SCTP docs tells me that
> SCTP events are not happening on every packet.
> They are ASSOC_CHANGE, PEER_ADDR_CHANGE, REMOTE_ERROR and such.
> Does not look performance critical.

Thanks.

But:

> diff --git a/net/sctp/ulpevent.c b/net/sctp/ulpevent.c
[]
> @@ -88,7 +88,7 @@ int sctp_ulpevent_is_notification(const struct sctp_ulpevent *event)
>  /* Hold the association in case the msg_name needs read out of
>   * the association.
>   */
> -static inline void sctp_ulpevent_set_owner(struct sctp_ulpevent *event,
> +static void sctp_ulpevent_set_owner(struct sctp_ulpevent *event,
>  					   const struct sctp_association *asoc)
>  {
>  	struct sctp_chunk *chunk = event->chunk;

This now misaligns the next line after the inline removal.

Can you please run your patches through checkpatch?

$ ./scripts/checkpatch.pl -
CHECK: Alignment should match open parenthesis
#86: FILE: net/sctp/ulpevent.c:92:
+static void sctp_ulpevent_set_owner(struct sctp_ulpevent *event,
 					   const struct sctp_association *asoc)
```