[PATCH][net-next] net: dsa: make function ksz_rcv static

Subsystems: microchip ksz series ethernet switch driver, networking [dsa], networking [general], the rest

STALE3428d

3 messages, 3 authors, 2017-06-01 · open the first message on its own page

[PATCH][net-next] net: dsa: make function ksz_rcv static

From: Colin King <hidden>
Date: 2017-06-01 12:22:54

From: Colin Ian King <redacted>

function ksz_rcv can be made static as it does not need to be
in global scope. Reformat arguments to make it checkpatch warning
free too.

Cleans up sparse warning: "symbol 'ksz_rcv' was not declared. Should
it be static?"

Signed-off-by: Colin Ian King <redacted>
---
 net/dsa/tag_ksz.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/dsa/tag_ksz.c b/net/dsa/tag_ksz.c
index 0b08a40b493a..dfcd2fff5b13 100644
--- a/net/dsa/tag_ksz.c
+++ b/net/dsa/tag_ksz.c
@@ -72,8 +72,9 @@ static struct sk_buff *ksz_xmit(struct sk_buff *skb, struct net_device *dev)
 	return nskb;
 }
 
-struct sk_buff *ksz_rcv(struct sk_buff *skb, struct net_device *dev,
-			struct packet_type *pt, struct net_device *orig_dev)
+static struct sk_buff *ksz_rcv(struct sk_buff *skb, struct net_device *dev,
+			       struct packet_type *pt,
+			       struct net_device *orig_dev)
 {
 	struct dsa_switch_tree *dst = dev->dsa_ptr;
 	struct dsa_switch *ds;
-- 
2.11.0

RE: [PATCH][net-next] net: dsa: make function ksz_rcv static

From: <Woojung.Huh@microchip.com>
Date: 2017-06-01 13:53:20

function ksz_rcv can be made static as it does not need to be
in global scope. Reformat arguments to make it checkpatch warning
free too.

Cleans up sparse warning: "symbol 'ksz_rcv' was not declared. Should
it be static?"

Signed-off-by: Colin Ian King <redacted>
Reviewed-by: Woojung Huh <Woojung.Huh@microchip.com>

Re: [PATCH][net-next] net: dsa: make function ksz_rcv static

From: David Miller <davem@davemloft.net>
Date: 2017-06-01 16:13:03

From: Colin King <redacted>
Date: Thu,  1 Jun 2017 13:22:42 +0100
From: Colin Ian King <redacted>

function ksz_rcv can be made static as it does not need to be
in global scope. Reformat arguments to make it checkpatch warning
free too.

Cleans up sparse warning: "symbol 'ksz_rcv' was not declared. Should
it be static?"

Signed-off-by: Colin Ian King <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help